Re: [OpenJDK 2D-Dev] Review: Remove private API from graphics code

Looks ok to me. -igor On 9/4/12 8:27 AM, Scott Kovatch wrote: (resending, now that I'm on 2d-dev.) I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/ In ImageSurfaceData, it looks like we are trying to get back to a pure CTM (i.e., no transform of any kind applie

Re: [OpenJDK 2D-Dev] Review fix for 7145771 : Register font failing

Looks good to me. On 6/25/12 1:59 PM, Phil Race wrote: Newly registered font was not listed because the CGraphicsEnvironment cached the list of fonts based on first use .. http://cr.openjdk.java.net/~prr/7145771.7u6/ -phil.

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

i am fine with the fix regardless of a way to detect Mac platform. -igor On 6/19/12 9:13 AM, Phil Race wrote: 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null http://cr.openjdk.java.net/~prr/7124536.7u6/ -phil.

Re: [OpenJDK 2D-Dev] [7u6] request for review: 7120895: FontConfiguration should not use thread contextClassLoader

Looks fine to me. -igor On 5/31/12 1:39 AM, Andrew Brygin wrote: Hello, could you please review a backport of the fix for 7120895 to 7u6? The problem there seems to be caused by an attempt to load sun.awt.HKSCS class using thread context classloader, that leads to loading lazy jars in cas

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

still seem ok to me. -igor On 3/21/12 1:17 AM, Jonathan Lu wrote: Hi, the original patch was not rebased to the latest 2d code, here's the rebased patch. http://cr.openjdk.java.net/~luchsh/7152519_2/jdk.patch Regards! - Jonathan On 03/21/2012 07:37 AM, Igor Nekrestyanov wrote: Looks

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Looks fine to me. -igor On 3/20/12 3:30 PM, Phil Race wrote: I'm (still) OK with this .. one other reviewer please somebody. -phil. On 3/20/2012 1:37 AM, Jonathan Lu wrote: Hello, could anyone please help to take a look at this splitted patch? Thanks! -Jonathan 2012/3/13 Jonathan Lu

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6968373: FontUtilities static initializer throws AccessControlException

Changeset: 2ad69cb576b4 Author:igor Date: 2010-07-12 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2ad69cb576b4 6968373: FontUtilities static initializer throws AccessControlException Reviewed-by: prr ! src/share/classes/sun/font/FontUtilities.java ! test/java/awt/Fon

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these)

Changeset: e03065fc64e7 Author:igor Date: 2010-07-12 13:16 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e03065fc64e7 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these) Reviewed-by: prr Contributed-by: ohair ! src/share/native/sun/

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6967050: JDK build issues with cygwin/vc2010

Changeset: ab55cb957830 Author:igor Date: 2010-07-06 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ab55cb957830 6967050: JDK build issues with cygwin/vc2010 Reviewed-by: prr, ohair ! make/common/shared/Defs-windows.gmk ! make/mkdemo/Makefile

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6952043: Incorrect JNI calls in fontpath.c

Changeset: 2574d999704a Author:igor Date: 2010-06-10 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2574d999704a 6952043: Incorrect JNI calls in fontpath.c Reviewed-by: jgodinez, prr ! src/windows/native/sun/font/fontpath.c

Re: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

Fix is ok with me. Here is the process description for openjdk6 - http://j2se.sfbay/web/bin/view/CoreTech/OpenJDK6 -igor On 3/3/10 7:01 AM, Roman Kennke wrote: This is the fix for the deadlock problem in SunGraphicsEnvironment/FontManager backported to OpenJDK6. It is slightly different from

Re: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

n (not for syncing) and it surely could use some cleanup, but I left it alone for now. http://cr.openjdk.java.net/~rkennke/6892485/webrev.01/ I need at least another review (not sure if Igor needs to say 'go' again?). Thanks, Roman Am Donnerstag, den 25.02.2010, 11:21 -0800 schri

Re: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

i am ok with this fix. -igor On 2/25/10 7:19 AM, Roman Kennke wrote: Hi there, this patch fixes the deadlock in FontManager for OpenJDK7 that has been reported repeatedly on this list. I have a testcase here (attached), which I could prepare for jtreg, but it is not totally reliable and depend

Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager"

Sorry for delay, i thought this one was reviewed. ok with me. -igor On 2/5/10 2:34 PM, Roman Kennke wrote: Am Mittwoch, den 03.02.2010, 11:55 -0800 schrieb Phil Race: looks fine. Good! Needs another reviewer? Igor maybe, or Dmitri? Thanks, Roman -phil On 2/3/2010 11:35 AM,

Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode

ok with me. -igor On 2/2/10 1:40 PM, Roman Kennke wrote: Here's the updated fix with testcase (I took the testcase from the bugreport and transformed it into a proper jtreg test). http://cr.openjdk.java.net/~rkennke/6896335/webrev.01/ Is this ok to put back? We also need another reviewer, Ig

Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

re! ;-) /Roman Dmitri Roman Kennke wrote: Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: As Dmitri mentioned you need to move policy file too. Otherwise test will not work in new location when run with jtreg. So I finally found some time to get back at th

Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

As Dmitri mentioned you need to move policy file too. Otherwise test will not work in new location when run with jtreg. Rest looks good to me. -igor On 12/7/09 12:12 PM, Roman Kennke wrote: Hi Phil, Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: Roman Kennke wrote: I a

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

I think that's ok. I can take Andrew's webrev and apply my changes and then putback to both workspaces. -igor On 10/26/09 1:16 PM, Phil Race wrote: Igor is also fixing the closed src .. -phil. Andrew John Hughes wrote: 2009/10/26 Igor Nekrestyanov : Andrew, i've filed 6

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

Andrew, i've filed 6895287 for this and plan to fix it soon. (this will likely a bit faster in terms of "time to get fix into master"). -igor On 10/26/09 11:19 AM, Andrew John Hughes wrote: 2009/10/26 Kelly O'Hair: Is someone fixing this bootstrap build problem with FontManager.getFontPat

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6887292: memory leak in freetypeScaler.c

Changeset: 31e68419715e Author:igor Date: 2009-10-02 10:15 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/31e68419715e 6887292: memory leak in freetypeScaler.c Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c

Re: [OpenJDK 2D-Dev] Review Request for 6879044

We have discussed this with Anthony and Andrei offline and they do not seem to have any blocking concerns. There is one suggestion though - there should be simple explanation for "are there any changes required on the end user side to enable logging and if so, what are they". Logging is mostly

Re: [OpenJDK 2D-Dev] Review Request for 6879044

ard compatibility - this will be even better.) -igor On 9/22/09 11:00 AM, Igor Nekrestyanov wrote: BTW, note that reducing set of required core classes will save 3x of memory at least (think of jqs and classes.jsa in addition to rt.jar (on windows)). -igor On 9/22/09 10:19 AM, Mandy Chung wro

Re: [OpenJDK 2D-Dev] Review Request for 6879044

BTW, note that reducing set of required core classes will save 3x of memory at least (think of jqs and classes.jsa in addition to rt.jar (on windows)). -igor On 9/22/09 10:19 AM, Mandy Chung wrote: (I took the core-libs-dev off as this is about awt/2d/swing discussion). The main question is

Re: [OpenJDK 2D-Dev] Review Request for 6879044

imho removing dependency on j.u.logging for me looks as strange as removing dependency on j.l.Object or java.util.* :) For example, if the libraries are broken up into a set of fine grain modules then why would I need to have a logging module installed to run a simple client application?

Re: [OpenJDK 2D-Dev] Review Request for 6879044

I would second to Oleg: improving the performance/design of the existing logging classes at java.util.logging package would help all applications at once. That certainly will be best thing to do but unfortunately it is not easy (possible?) maintaining backward compatibility. Several people h

Re: [OpenJDK 2D-Dev] Using OpenJDK's FreeType support in a standard Sun JRE

Hello Daniel, It is not possible to simply copy part of openjdk to your application in order to add support for plugging freetype. It does require changes in the jdk libraries itself to support concept of pluggable rasterizers. In theory it might be possible to use your own rasterizer (and yo

Re: [OpenJDK 2D-Dev] JNI crashes in FontManager code

in testing by users seems pretty high priority. Martin On Tue, Oct 21, 2008 at 02:13, Igor Nekrestyanov wrote: Thanks! I've filed bug 6761791 and plan to evaluate suggested fix in more details/fix the bug soon. -igor Martin Buchholz wrote: Igor, I did some more digging, and I h

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6761791: Crash in the FontManager code due to use of JNIEnv saved by another thread

Changeset: 11d333de082f Author:igor Date: 2008-12-17 22:00 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/11d333de082f 6761791: Crash in the FontManager code due to use of JNIEnv saved by another thread Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c

Re: [OpenJDK 2D-Dev] 6782079: PNG: reading metadata may cause OOM on truncated images

Hi Martin, There was a hunk in my patch changing the possible valies for compressionFlag of an iTXtEntry from 1/0 to TRUE/FALSE. YOu moved this change to your patch for 5082756. That's OK by me, but requires patches to be applied in the corret order. That's the reason I had that change bundled wi

Re: [OpenJDK 2D-Dev] JNI crashes in FontManager code

Yes, we certainly will integrate fix for this problem soon. Forgot to submit updated fix for review before vacation. Will do this week. -igor Martin Buchholz wrote: Ping. A crash found in testing by users seems pretty high priority. Martin On Tue, Oct 21, 2008 at 02:13, Igor Nekrestyanov

Re: [OpenJDK 2D-Dev] Still waiting for review

Hi Mark and Martin, sorry for delay with our responses. Many of us were involved into FX prerelease activities and had to postpone some of openjdk work. My understanding of current situation with Martin's fixes is the following: - for 2 of Martin's fixes internal formal review procedure is i

Re: [OpenJDK 2D-Dev] JVM Crash: printing character \u0DDD in Swing app

Hi Patrick, thank you for tracking down this problem. to simplify testcase please do the following: 1) render to the offscreen bufferedimage, so no swing will be involved Like this? (in a loop) BufferedImage bimg = gconf.createCompatibleImage(100, 100); Graphics g = bimg.getGraphics();

Re: [OpenJDK 2D-Dev] JVM Crash: printing character \u0DDD in Swing app

Hi, thank you for your report! to simplify testcase please do the following: 1) render to the offscreen bufferedimage, so no swing will be involved 2) iterate through list of font files, we need to find which font exactly causes the problem In other words ideal testcase simply draws singl

Re: [OpenJDK 2D-Dev] Bug in pisces Renderer (uninitialized crossings)

Hi Mark, your patch looks ok to me but i am not expert in pisces. Alexey Ushakov, who is our expert in pisces should have returned from vacation today and i think he will review this soon. -igor Mark Wielaard wrote: Hi, On Tue, 2008-11-04 at 10:30 +0100, Mark Wielaard wrote: If anybody

Re: [OpenJDK 2D-Dev] Bug fixes for com.sun.imageio.plugins.png.PNGMetadata

Hi Martin, yes, this is correct list for ImageIO fixes. I am not ImageIO expert and someone who better understands this code will need to review this. If changes are ok then we will integrate it acknowledging your contribution. Usually it is more convenient to deal with independent issues se

Re: [OpenJDK 2D-Dev] Bad component spacing

Thank you Mark! i keep forgetting that bug database is not available to everyone yet :( -igor Mark Wielaard wrote: Hi, On Thu, 2008-11-06 at 20:47 +0300, Igor Nekrestyanov wrote: This is likely to be same as http://monaco.sfbay.sun.com/detail.jsf?cr=6761856 that was recently fixed and

Re: [OpenJDK 2D-Dev] Bad component spacing

This is likely to be same as http://monaco.sfbay.sun.com/detail.jsf?cr=6761856 that was recently fixed and did not make it into main openjdk ws yet but you can pull these changes from 2D workspace to test. -igor Artem Ananiev wrote: Hi, Marek, as your test uses Swing menus, it looks like a

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6761856: OpenJDK: vertical text metrics may be significanly different from those returned by Sun JDK

Changeset: 9cdababf6179 Author:igor Date: 2008-10-29 01:52 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9cdababf6179 6761856: OpenJDK: vertical text metrics may be significanly different from those returned by Sun JDK Reviewed-by: bae, prr ! src/share/native/sun/font/free

Re: [OpenJDK 2D-Dev] openjdk incompatibility

This issues now has bug id: 6761856 -igor Phil Race wrote: You didn't show what the result was from OpenJDK Seems the complaint here is the that the position of the vertical bounds is suspect. Looks like the sign is incorrect in some code that interfaces to freetype and returns glyph bounds

Re: [OpenJDK 2D-Dev] JNI crashes in FontManager code

Thanks! I've filed bug 6761791 and plan to evaluate suggested fix in more details/fix the bug soon. -igor Martin Buchholz wrote: Igor, I did some more digging, and I have a stack trace for you Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x29

Re: [OpenJDK 2D-Dev] JNI crashes in FontManager code

Hi, Suggested changes seems reasonable. However, i failed to invent testcase to reproduce this issue. Could you please describe what google test is doing in regard to the font code? It first glance it seems that the only way to get into freetypeScaler.c is through synchronized methods and env

Re: [OpenJDK 2D-Dev] [PATCH] FontManager refactoring

Wow, that's the large one. It will take some time for me to look through this and Phil is the right guy to review most of these changes anyway. Just few small comments for now. I see that in number of places static variables are upper case. E.g. number of variables in the FontUtilities. I am n

Re: [OpenJDK 2D-Dev] JNI crashes in FontManager code

Hello Martin, Suggested changes seems reasonable. However, i failed to invent testcase to reproduce this issue. Could you please describe what google test is doing in regard to the font code? It first glance it seems that the only way to get into freetypeScaler.c is through synchronized metho

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

Minimal changes are always good idea. However, we usually do not add new methods unless we actually use them. Not sure what's the best approach in this case. -igor Roman Kennke wrote: Am i understanding this correctly and this adds new TrueType constructor that is not used in the OpenJDK itself

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

Am i understanding this correctly and this adds new TrueType constructor that is not used in the OpenJDK itself? -igor Roman Kennke wrote: Hi there, What do you think about this patch (see webrev link below)? Can we get this into jdk7? It is very useful for me and I wouldn't like to maintain

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

- It probably does increase perceived footprint although results will probably vary by platform and we'd need to see if people will accept that. I did what I hope is a reasonably fair comparison of the two approaches, reading all font files on my XP system takes mem usage up to 160Mb

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

This is weird. I suggest to print out font names and find what is different. Perhaps we do have bug somethere in 7. -Dsun.java2d.debugfonts=true may also provide some details on files being opened. I checked an older version that I have lying around here (from just before Phil's font wo

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

Quick tests are: run Font2DTest on system that has some really large ttf/ttc files. Write simple test that iterates through all available fonts and draw one or all glyphs to bufferedimage. I wrote a simple test program that gets an array of all fonts and gets the baseline for all 0-0xf

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

Hi, Yep, Phil is the one who designed font management code. I can't wait for Phil to come back and have a look at our redesign of the FontManager related code :-) (Maybe it's not so bad that I am in holiday then .. ;-) ). But this one here is not so much about FontManager but more about th

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

Yep, Phil is the one who designed font management code. I remember there were some important reasons why callback-based approach was introduced but can not recall them right now. From the top of the head i'd sugegst to check impact of such change on performance and perceived footprint scannin

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 4356282: RFE: T2K should be used to rasterize CID/CFF fonts

Changeset: e62bc7b05b8a Author:igor Date: 2008-08-04 18:50 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e62bc7b05b8a 4356282: RFE: T2K should be used to rasterize CID/CFF fonts Reviewed-by: bae, prr ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font

Re: [OpenJDK 2D-Dev] Linking problems in Solaris :-/

Hello Clemens, i do not know the answer but perhaps it will help if you can post exact link command that fails, error message and relevant part of output of nm command. -igor Clemens Eisserer wrote: Hello, I am currently trying to build my pipeline on Solaris, however libfontmanager.so fai

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6720240: IOB exception when getting font metrics of hershey font

Changeset: c1e0755434eb Author:igor Date: 2008-07-15 16:04 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c1e0755434eb 6720240: IOB exception when getting font metrics of hershey font Reviewed-by: bae, prr ! src/share/classes/sun/font/NullFontScaler.java

Re: [OpenJDK 2D-Dev] CFV: Doug Felt to Membership in the 2D group

vote: yes -igor Phil Race wrote: I hereby nominate Doug Felt as a member of the OpenJDK 2D group. Doug has made significant contributions to the Java 2D text APIs and their implementation starting in 1997 and in every release from JDK 1.2 up to and including JDK 6. As part of the Taligent (

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6587560: OpenJDK problem handling bitmaps returned when LCD text is requested

Changeset: 8f1a1b2f77a3 Author:igor Date: 2008-05-28 20:06 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8f1a1b2f77a3 6587560: OpenJDK problem handling bitmaps returned when LCD text is requested Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6703377: freetype: glyph vector outline is not translated correctly

Changeset: 7fba83f5f5e0 Author:igor Date: 2008-05-21 10:59 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7fba83f5f5e0 6703377: freetype: glyph vector outline is not translated correctly Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c + test/java/awt/font/

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6630501: CRASH: JCK test eats much memory and jvm crashes

Changeset: bf2c66511d1b Author:igor Date: 2008-05-16 03:10 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/bf2c66511d1b 6630501: CRASH: JCK test eats much memory and jvm crashes Reviewed-by: bae, prr ! src/share/classes/sun/font/Type1Font.java

Re: [OpenJDK 2D-Dev] Font question

Looking at your screenshot again i started to doubt it is because of outlines - i do not see any dropouts and these are common if geometric code does scan conversion. What style of font is it? Is it plain or bold? We do change processing logic for styled text (request outline, style it and then

Re: [OpenJDK 2D-Dev] Font question

Hi Roman, However, there seems to be a problem related to fonts. To me, it looks like they are not hinted properly. My TextRenderer implementation is very simple and straightforward: The only control for font hinting is how the rasteriser - freetype - is compiled. If your copy of libf

Re: [OpenJDK 2D-Dev] CFV: Project sponsorship: XRender Java2D Pipeline

votes cast. The votes will be tallied and reported to this list and to [EMAIL PROTECTED] Only Members of the 2D Group are eligible to vote on this decision. The current Members are: Andrew Brygin Brian Burkhalter Christopher Campbell Jerry Evans Jennifer Godinez Jim Graham Steven Loomis Igor

Re: [OpenJDK 2D-Dev] Freetype font rasteriser

Hi, Just wondering if anyone has any comments/bugs/patches etc on the freetype replacement for the encumbered font rasteriser that we finally put out last week? I haven't had a chance to go over it in much detail (I've been busy with other non-openjdk work), but the only bug I've found so far

Re: [OpenJDK 2D-Dev] Freetype font rasteriser

Ok, I'll see if I can come up with something after/while studying the implementation. I suggest to have a look to FontScaler.java for start. -igor

Re: [OpenJDK 2D-Dev] Freetype font rasteriser

Hi Roman, are you using latest binary plugs? I believe this particular was recently added (b16 or b17) and it seems it was not pulled correctly. Could it be that you were using old version of plugs? These is no complete documentation yet. Bits of available documentation are spread out as comme

Re: [OpenJDK 2D-Dev] OpenJDK: Question on Bug 4197755

the bounding box and not to calculate it precisely. Regards Alex "Igor Nekrestyanov" <mailto:[EMAIL PROTECTED]> schrieb: > Hi, > > > > So i assume this only a problem on Windows plattforms and there is > > already a suggestion for a fix - i dont know if

Re: [OpenJDK 2D-Dev] OpenJDK: 2D API Contributions

Hello Alexander, Have a look at overview of contribution process here - http://openjdk.java.net/contribute/. Process is evolving and hopefully will be simplified with time (in particular after after openjdk will finally migrate to Mercurial repositary). If you want to help with improving Open