Re: [OpenJDK 2D-Dev] RFR: 8273140: Replace usages of Enum.class.getEnumConstants() with Enum.values() where possible

2021-08-30 Thread Joe Darcy
On Mon, 30 Aug 2021 14:26:56 GMT, Сергей Цыпанов wrote: > Just a very tiny clean-up. > > There are some places in JDK code base where we call > `Enum.class.getEnumConstants()` to get all the values of the referenced > `enum`. This is excessive, less-readable and slower than just calling > `E

Re: [OpenJDK 2D-Dev] RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Joe Darcy
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28

Re: [OpenJDK 2D-Dev] JDK 14 RFR of JDK-8231334: Suppress warnings on non-serializable instance fields in client libs serializable classes

2019-09-24 Thread Joe Darcy
proved by me .. but .. it would be good if you can point out any other cases where you think we can compatibly make changes to get rid of the need for suppressing this new warning. -phil On 9/23/19, 12:54 PM, Joe Darcy wrote: Hi Phil, On 9/22/2019 1:25 PM, Philip Race wrote: + @Suppress

Re: [OpenJDK 2D-Dev] JDK 14 RFR of JDK-8231334: Suppress warnings on non-serializable instance fields in client libs serializable classes

2019-09-23 Thread Joe Darcy
re meant to the an aid, especially to writing new serializable types, while also prompting some examination of the existing types in an effort to allow the warning to enabled by default  in the build. Thanks, -Joe -phil On 9/21/19, 12:48 PM, Joe Darcy wrote: Hello, Quick background, I'

[OpenJDK 2D-Dev] JDK 14 RFR of JDK-8231334: Suppress warnings on non-serializable instance fields in client libs serializable classes

2019-09-21 Thread Joe Darcy
Hello, Quick background, I'm working on expanding the compile-time serialization checks of javac's -Xlint:serial option. Ahead of that work going back, I'm analyzing the JDK sources and plan to pre-suppress the coming-soon new warnings, fixing or at least filing follow-up bugs for any problem

[OpenJDK 2D-Dev] Fwd: Re: JDK 9 pre-review of JDK-6850612: Deprecate Class.newInstance since it violates the checked exception language contract

2016-04-26 Thread joe darcy
/6850612.0/ Thanks, -Joe Forwarded Message Subject: Re: JDK 9 pre-review of JDK-6850612: Deprecate Class.newInstance since it violates the checked exception language contract Date: Thu, 21 Apr 2016 09:25:27 -0700 From: joe darcy Organization: Oracle Corporation To:

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8149896: Remove unnecessary values in FloatConsts and DoubleConsts

2016-02-16 Thread joe darcy
Hi Laurent, On 2/16/2016 2:08 AM, Laurent Bourgès wrote: Hello, Joe, I tested your changes in the Marlin renderer as it works well ! > A quick note on the 2d changes, several constants (and a copy from a package-private method from java.lang) were used to initialize a double value

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8148914: BitDepth.java test fails

2016-02-15 Thread joe darcy
ext(); File file = new File("BitDepth_" + biTypeNames[type] + "." + format); if (!writers.hasNext()) { System.out.println(“No writers available for type “ + biTypeNames[type] + " BufferedImage!"); } else { ImageWriter writer = writers.next(); t

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8149896: Remove unnecessary values in FloatConsts and DoubleConsts

2016-02-15 Thread joe darcy
Hello, The the FloatConsts and DoubleConsts classes, while moved to an internal package recently (JDK-8145990), contain constants now available via the public API. All such uses of the redundant values should be removed as well as the redundant constants themselves. A quick note on the 2d ch

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8148914: BitDepth.java test fails

2016-02-15 Thread joe darcy
Any comments on this? Thanks, -Joe On 2/11/2016 6:00 PM, joe darcy wrote: Hello, Please review a candidate fix for JDK-8148914: BitDepth.java test fails In brief, OpenJDK supports two fewer buffered image formats for jpg than the closed JDK does. I've modified the BitDepth te

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8148914: BitDepth.java test fails

2016-02-11 Thread joe darcy
Hello, Please review a candidate fix for JDK-8148914: BitDepth.java test fails In brief, OpenJDK supports two fewer buffered image formats for jpg than the closed JDK does. I've modified the BitDepth test to allow for this difference. Patch below; webrev at http://cr.openjdk.java.ne

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8144627: Problem list WriteAfterAbort.java

2015-12-03 Thread joe darcy
The other failing test is closed and I will send a separate (internal) review for that one :-) Thanks, -Joe On 12/3/2015 1:10 PM, Phil Race wrote: I thought it was two tests ? -phil. On 12/03/2015 01:09 PM, joe darcy wrote: Hello, The test javax/imageio/plugins/shared

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8144627: Problem list WriteAfterAbort.java

2015-12-03 Thread joe darcy
Hello, The test javax/imageio/plugins/shared/WriteAfterAbort.java is failing and should be problem listed until the underlying problem is fixed (JDK-8144554). Please review the patch below which does this. Thanks, -Joe --- a/test/ProblemList.txtThu Dec 03 11:53:00 2015 -0800 +++ b

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
time) { try { // add +/-5ms variance to increase randomness Thread.sleep(time + (long)(5 - Math.random()*10)); } catch (InterruptedException e) {}; } -Joe -phil. On 8/20/2015 11:44 AM, joe darcy wrote: Hi Phil, On 8/20/2015 11:14 AM, Phil Race wrote

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
HTH, -Joe -phil. On 08/20/2015 10:47 AM, joe darcy wrote: Hello, As part of implementing tiered testing [1], client library tests which use randomness should be marked with the corresponding keyword. The analogous changes have been made in core libs, see JDK-8078334: Mark regression tests

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
Hello, As part of implementing tiered testing [1], client library tests which use randomness should be marked with the corresponding keyword. The analogous changes have been made in core libs, see JDK-8078334: Mark regression tests using randomness. Webrev at JDK-8134084 : Mark client l

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8132500: Add imageio test to tier 3

2015-07-28 Thread joe darcy
Hello, Please review the small patch below to address JDK-8132500: Add imageio test to tier 3 by adding the jdk_imageio test group to tier 3. Thanks, -Joe diff -r 1d42e865f18c test/TEST.groups --- a/test/TEST.groupsThu Jul 23 16:46:54 2015 +0300 +++ b/test/TEST.groupsTue Jul 28 2

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8129822: Define "headful" jtreg keyword

2015-06-24 Thread joe darcy
Hello, To support the next iteration of tiered testing in JDK 9, with an eye toward running client library tests, please review the patch below which addresses JDK-8129822: Define "headful" jtreg keyword Some test environments are headless, including test environments often used for the

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread joe darcy
/2014-December/004992.html http://mail.openjdk.java.net/pipermail/awt-dev/2014-December/008790.html Thanks, -Joe On 12/16/2014 9:24 AM, Phil Race wrote: Approved. We really need to figure out what to do about getPeer() - for this and for jigsaw .. -phil. On 12/16/2014 9:10 AM, joe darcy wrote

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread joe darcy
On 12/16/2014 3:15 AM, Alan Bateman wrote: On 16/12/2014 06:07, joe darcy wrote: Hello, Please review the next step of suppressing the deprecation warnings the client libraries, this time in windows-specific desktop code: JDK-8067092: Suppress windows-specific deprecation warnings in

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067086: Suppress mac-specific deprecation warnings in the java.desktop module

2014-12-15 Thread joe darcy
Hello, Please review this (hopefully) last change to suppress the deprecation warnings in the java.desktop module: 8067086: Suppress mac-specific deprecation warnings in the java.desktop module http://cr.openjdk.java.net/~darcy/8067086.0/ Thanks, -Joe

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-15 Thread joe darcy
Hello, Please review the next step of suppressing the deprecation warnings the client libraries, this time in windows-specific desktop code: JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module http://cr.openjdk.java.net/~darcy/8067092.0/ Thanks, -

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

2014-12-15 Thread joe darcy
On 12/15/2014 11:48 AM, Phil Race wrote: On 12/12/14 5:35 PM, joe darcy wrote: Hi Phil, On 12/12/2014 12:46 PM, Phil Race wrote: Hi, You did not provide a direct reference to the set of warnings that were generated. fortunately I found it here :- https://bugs.openjdk.java.net/browse/JDK

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

2014-12-12 Thread joe darcy
mplicitly declared, unless: * [...] * The use and declaration are both within the same outermost class. " http://docs.oracle.com/javase/specs/jls/se8/html/jls-9.html#jls-9.6.4.6 Thanks for the review, -Joe If so then perhaps the module idea above can be considered an extension of th

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

2014-12-10 Thread joe darcy
ytecode), there will no be functional change in the output based on this changeset. Therefore, as long as a build succeeds, I don't see what difference client SQE testing would make in this particular case. -Joe Victor On 10.12.2014 3:41, joe darcy wrote: Hello, In support of JEP 212:

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

2014-12-09 Thread joe darcy
Hello, In support of JEP 212: Resolve Lint and Doclint Warnings (http://openjdk.java.net/jeps/212), which is targeted to JDK 9, please review the large but straightforward set of changes in the webrev: http://cr.openjdk.java.net/~darcy/8066621.0/ Some background of the approach being tak

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8048980 : Fix raw and unchecked lint warnings in platform-specific sun.font files

2014-07-03 Thread Joe Darcy
A nice small fix, ready to review... Thanks, -Joe On 07/01/2014 05:35 PM, Joe Darcy wrote: Hello, Please review this small change to address a few remaining unchecked and raw types warnings in platform-specific sun.font code; full patch below: JDK-8048980 : Fix raw and unchecked lint

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8048980 : Fix raw and unchecked lint warnings in platform-specific sun.font files

2014-07-01 Thread Joe Darcy
Hello, Please review this small change to address a few remaining unchecked and raw types warnings in platform-specific sun.font code; full patch below: JDK-8048980 : Fix raw and unchecked lint warnings in platform-specific sun.font files http://cr.openjdk.java.net/~darcy/8048980.0/

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042870: Fix raw and unchecked warnings in sun.print

2014-06-09 Thread Joe Darcy
Hi Phil, On 06/09/2014 11:33 AM, Phil Race wrote: All seems fine. Just a couple of observation/questions .. 1. I see you found an unused variable in ServiceDialog .. Yep; seemed better to delete it than generify it unnecessarily :-) 2. IPPPrintService.java 1791 ArrayList> respList = n

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042870: Fix raw and unchecked warnings in sun.print

2014-06-08 Thread Joe Darcy
Hello, Please review my proposed changes to address JDK-8042870: Fix raw and unchecked warnings in sun.print http://cr.openjdk.java.net/~darcy/8042870.0/ (This is the largest remaining grouping of raw and unchecked warnings in a single package in the jdk repo.) Thanks, -Joe

Re: [OpenJDK 2D-Dev] RFR: 8044551, 8044396: Fix raw and unchecked lint warnings in platform-specific sun.awt and sun.java2d

2014-06-05 Thread Joe Darcy
Hi Henry, From a quick look, the changes seem fine. Thanks, -Joe On 06/05/2014 04:51 PM, Henry Jen wrote: Hi, Please review a follow-up to clean up rawtype and unchecked warnings in platform-specific code. Bug: https://bugs.openjdk.java.net/browse/JDK-8044396 https://bugs.openjdk.java.net

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8044694: Fix finally lint warnings in sun.print

2014-06-03 Thread Joe Darcy
()); } } -phil. On 6/3/2014 10:11 AM, Joe Darcy wrote: Hello, Please review a fix for JDK-8044694: Fix finally lint warnings in sun.print http://cr.openjdk.java.net/~darcy/8044694.0/ One of javac's lint warnings is for a finally block that cannot complete normally. The pri

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8044694: Fix finally lint warnings in sun.print

2014-06-03 Thread Joe Darcy
Hello, Please review a fix for JDK-8044694: Fix finally lint warnings in sun.print http://cr.openjdk.java.net/~darcy/8044694.0/ One of javac's lint warnings is for a finally block that cannot complete normally. The printing code has two instances with a finally block like

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Joe Darcy
Revised webev at http://cr.openjdk.java.net/~darcy/8042864.2 Comments below. On 05/19/2014 12:14 PM, Phil Race wrote: On 5/19/2014 11:54 AM, Joe Darcy wrote: http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java.sdiff.html

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Joe Darcy
when possible. Thanks, -Joe | -phil. | On 05/19/2014 09:35 AM, Joe Darcy wrote: *ping* Any other comments? Thanks, -Joe On 05/15/2014 06:06 PM, Joe Darcy wrote: Hi Henry, On 05/15/2014 03:46 PM, Henry Jen wrote: On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review thes

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Joe Darcy
*ping* Any other comments? Thanks, -Joe On 05/15/2014 06:06 PM, Joe Darcy wrote: Hi Henry, On 05/15/2014 03:46 PM, Henry Jen wrote: On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-15 Thread Joe Darcy
Hi Henry, On 05/15/2014 03:46 PM, Henry Jen wrote: On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print http://cr.openjdk.java.net/~darcy/8042864.0/ Patch below. Looks good to me, just nit

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-15 Thread Joe Darcy
Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print http://cr.openjdk.java.net/~darcy/8042864.0/ Patch below. Thanks, -Joe --- old/src/share/classes/javax/print/AttributeException.java 2014-05-15 12:04:19.0 -0700 +++ new/src/s

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8039109 : Fix unchecked and raw lint warnings in java.awt

2014-05-05 Thread Joe Darcy
hich is usually a worse trade-off. Thanks, -Joe -phil. On 5/5/2014 3:22 PM, Jim Graham wrote: I took a look at the j.a.image and j.a.geom files and everything looked fine. ...jim On 5/4/14 9:44 AM, Joe Darcy wrote: Hello, Any further comments on the latest version http://cr.

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8039862: Fix fallthrough lint warnings in 2d

2014-04-15 Thread Joe Darcy
*ping* On 04/09/2014 07:51 PM, Joe Darcy wrote: Hello, Please review these fixes for JDK-8039862: Fix fallthrough lint warnings in 2d http://cr.openjdk.java.net/~darcy/8039862.0/ In particular, it wasn't entirely clear that the fall through cases in src/share/classes/sun

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8039862: Fix fallthrough lint warnings in 2d

2014-04-09 Thread Joe Darcy
Hello, Please review these fixes for JDK-8039862: Fix fallthrough lint warnings in 2d http://cr.openjdk.java.net/~darcy/8039862.0/ In particular, it wasn't entirely clear that the fall through cases in src/share/classes/sun/font/TrueTypeGlyphMapper.java were intended. Thanks, -Joe

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8039342: Fix raw and unchecked warnings in sun.awt.*

2014-04-07 Thread Joe Darcy
Hi Henry, Thanks for looking into this. FWIW, while I was working on JDK-8039109: Fix unchecked and raw lint warnings in java.awt I started looking at some sun.awt.* type too and I noticed the same problem in AreaOp.pruneEdges(). The comment I added to my in-progress webrev is: 203

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8038644: Fix raw and unchecked warnings in sun.java2d.*

2014-03-28 Thread Joe Darcy
Looks good Henry. Thanks, -Joe On 3/28/2014 10:01 AM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in sun.java2d packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8038644/0/webrev/ Cheers, Henry

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8037139: Fix serial lint warnings in sun.print

2014-03-11 Thread Joe Darcy
Hello, Please review these changes to fix the serial lint warnings in the sun.print package: http://cr.openjdk.java.net/~darcy/8037139.0/ Thanks, -Joe

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8035487: Fix raw and unchecked lint warnings in javax.imageio.spi

2014-02-21 Thread Joe Darcy
On 02/20/2014 10:01 PM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in javax.imageio.spi packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8035487/0/webrev/ Cheers, Henry Hi Henry, From a quick look, I didn`t see anything amiss with your changes

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8034998: Fix raw and unchecked lint warnings in javax.imageio

2014-02-15 Thread Joe Darcy
On 02/14/2014 06:43 PM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in javax.imageio packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8034998/0/webrev/ The webrev does not cover javax.imageio.spi, that will come in anoter webrev. Cheers, Henry

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8034050: Fix serial lint warnings in javax.print

2014-02-09 Thread Joe Darcy
Hello, Please review the proposed fix for JDK-8034050: Fix serial lint warnings in javax.print http://cr.openjdk.java.net/~darcy/8034050.0/ I checked that the added serialVerionUID values match the serialver computations for those types on JDK 6 and 8. Thanks, -Joe --- old/src/shar

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-07 Thread Joe Darcy
Hello, On 02/06/2014 04:13 PM, Phil Race wrote: Comments/questions on the changes :- Font2D.java 108 protected Reference lastFontStrike = new SoftReference<>(null); ... 320 lastFontStrike = new SoftReference<>(strike); So the diamond operator can be used in this 2nd case ? Apparently

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-06 Thread Joe Darcy
il/awt-dev/2014-February/006934.html -Joe -phil. On 2/6/2014 9:54 AM, Joe Darcy wrote: On 02/06/2014 12:48 AM, Alan Bateman wrote: On 05/02/2014 23:55, Phil Race wrote: Joe, This help is very much appreciated but can you please re-generate your webrev against jdk9/client and I'll review i

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-06 Thread Joe Darcy
On 02/06/2014 11:12 AM, Alan Bateman wrote: On 06/02/2014 19:01, Phil Race wrote: Joe, We will get an integration going soon, so you won't have to wait too long. Its more important to be consistent in that we get the client code in the client forest. We already had to deal with a merge proble

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-06 Thread Joe Darcy
On 02/06/2014 12:48 AM, Alan Bateman wrote: On 05/02/2014 23:55, Phil Race wrote: Joe, This help is very much appreciated but can you please re-generate your webrev against jdk9/client and I'll review it then. If this is a problem for you then instead I can take your final patch and commit in

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-05 Thread Joe Darcy
On 02/05/2014 01:51 AM, Alan Bateman wrote: On 05/02/2014 07:41, Joe Darcy wrote: Hello, Please review this change which resolves ~200 raw and unchecked warnings in sun.font. (Afterward, the code is also free the of the "cast" warning.) JDK-8033624 : Fix raw and unchecked lin

Re: [OpenJDK 2D-Dev] JDK 9: RFR: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-05 Thread Joe Darcy
Hi Henry, On 02/05/2014 12:19 PM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in com.sun.imageio packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/0/webrev/ The more significant change in this webrev is that I have changed the clone() met

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-04 Thread Joe Darcy
Hello, Please review this change which resolves ~200 raw and unchecked warnings in sun.font. (Afterward, the code is also free the of the "cast" warning.) JDK-8033624 : Fix raw and unchecked lint warnings in sun.font http://cr.openjdk.java.net/~darcy/8033624.0/ Thanks, -Joe

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033616 : Fix serial lint warnings in javax.imageio.*

2014-02-04 Thread Joe Darcy
Hello, Please review this simple patch to add serialVersionUID fields to several serializable types in javax.imageio. JDK-8033616 : Fix serial lint warnings in javax.imageio.* http://cr.openjdk.java.net/~darcy/8033616.0/ I've verified the serialVersionUID values have been stable acro

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]}

2014-01-31 Thread Joe Darcy
*ping* Thanks, -Joe On 01/29/2014 10:17 PM, Joe Darcy wrote: PS I updated the webrev to include changes to two additional files: diff -r a4c07ee72d07 src/share/classes/com/sun/imageio/plugins/common/BogusColorSpace.java --- a/src/share/classes/com/sun/imageio/plugins/common

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]}

2014-01-29 Thread Joe Darcy
ssWarnings("serial") // JDK-implementation class private class IllegalThumbException extends Exception {} /** Thanks, -Joe On 01/29/2014 10:10 PM, Joe Darcy wrote: Hello, As another installment of addressing the serial warnings in the client libraries, please review my changes fo

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]}

2014-01-29 Thread Joe Darcy
Hello, As another installment of addressing the serial warnings in the client libraries, please review my changes for: JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]} http://cr.openjdk.java.net/~darcy/8033223.0/ Patch below. Thanks, -Joe --- old/src/share/classes/su

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

2014-01-27 Thread Joe Darcy
On 01/27/2014 12:04 AM, Alan Bateman wrote: On 26/01/2014 09:30, Alan Bateman wrote: The only non-client changes that I see are to Setup.gmk (previously reviewed on build-dev) and Sdp.java. I see the others now, just hard to spot in a large mind-numbing patch :-) All looks good but as I look a

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

2014-01-25 Thread Joe Darcy
Hello, Please review my large, but largely straightforward, changes to fix JDK-8032733: Fix cast lint warnings in client libraries http://cr.openjdk.java.net/~darcy/8032733.0/ Many of the changes were enabled by the clone method of an array being redefined to return the array's type ra

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Joe Darcy
be done too? Thanks, -Joe On 18.01.2014 3:24, Joe Darcy wrote: Hello, An update, good news / bad news from the jprt job; the jprt job failed, but there was only a single missed instance of a static warning in the sources to the jdk repo: src\windows\classes\sun\java2d\d3d

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Joe Darcy
, Joe Darcy wrote: Hello, I've had a jprt job submitted to make sure that aren't any cross-platform build issues (and to flush out any other static warnings in the code base). If the jprt is successful, I'll push the changes proposed so far. Thanks Petr and Sergey for the review

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Joe Darcy
1/17/2014 02:12 PM, Petr Pchelko wrote: Hello, Joe. The final version still looks good. With best regards. Petr. 18 янв. 2014 г., в 1:47 до полудня, Sergey Bylokhov написал(а): Hello, Joe. This version looks good to me too. On 18.01.2014 1:13, Joe Darcy wrote: PS I neglected to include some

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Joe Darcy
Renderer.drawGlyphVector(sg2d, g, x, y); + SurfaceData.lcdTextRenderer.drawGlyphVector(sg2d, g, x, y); return; default: } On 01/17/2014 11:30 AM, Joe Darcy wrote: Hi Sergey, On 01/17/2014 02:28 AM, Sergey Bylokhov wrote: Hello, Joe. Some comments: - in the SunDropTargetCon

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Joe Darcy
StyledEditorKit.java and HTMLEditorKit.java, because defaultActions is a private static field and it can be accessed directly. Improved. New webrev: http://cr.openjdk.java.net/~darcy/8032047.2 Thanks for the review, -Joe On 17.01.2014 11:31, Joe Darcy wrote: Hi Petr, On 01/16/2014 11:20

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-16 Thread Joe Darcy
tD3DDevice is just a getter, it does not allocate new object and has no side effects.. Changed. Revised webrev at http://cr.openjdk.java.net/~darcy/8032047.0/ Thanks for the careful review, -Joe With best regards. Petr. On 17.01.2014, at 10:55, Joe Darcy wrote: Hello, Please view m

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-16 Thread Joe Darcy
Hello, Please view my proposed fix for JDK-8032047: Fix static lint warnings in client libraries http://cr.openjdk.java.net/~darcy/8032047.0/ Mostly this fix consisted of just replacing a variable name with the class name mentioned by javac in the warning message. In a few cases where

[OpenJDK 2D-Dev] JDK 9 RFR of a missing @param tag in javax.print.PrintService

2014-01-10 Thread Joe Darcy
Hello, Please review the patch below to fix a missing @param tag for a type variable defined in javax.print.PrintService. Thanks, -Joe diff -r 34b36f75d2d7 src/share/classes/javax/print/PrintService.java --- a/src/share/classes/javax/print/PrintService.javaFri Jan 10 09:24:47 2014 -0800

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8031082 Fix non-missing doclint problems in client libraries

2014-01-10 Thread Joe Darcy
On 01/10/2014 04:55 AM, Sergey Bylokhov wrote: On 09.01.2014 23:56, Joe Darcy wrote: Hello Sergey, On 1/8/2014 11:53 PM, Sergey Bylokhov wrote: Hello, Joe. Why @see tag was removed in the ComponentPeer.java? Because they were resulting in "error: reference not found" messages.

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8031082 Fix non-missing doclint problems in client libraries

2014-01-09 Thread Joe Darcy
new year! Happy new year! In case this was overlooked during the new year's holiday, please look over the changes in http://cr.openjdk.java.net/~darcy/8031082.0/ which resolve many of the outstanding doclint issues in the client libraries. Thanks, -Joe On 12/31/2013 12:51 AM, Jo

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8031082 Fix non-missing doclint problems in client libraries

2013-12-31 Thread Joe Darcy
Hello, Please review my fix for JDK-8031082 Fix non-missing doclint problems in client libraries The fix resolves nearly all of the outstanding doclint issues in the client libraries, others than the missing javadoc tags. The affected files are src/share/classes/java/awt/Graphics2D.java

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

2013-11-20 Thread Joe Darcy
Hello, I'm not an HTML expert, but it seems preferable to me to just remove an unnecessary "" tag rather than replacing it with "". Is there a reason to prefer ""? Otherwise the changes look fine. Thanks, -Joe On 11/20/2013 1:47 AM, Sergey Lugovoy wrote: Hi all, please review the fix. bug

Re: [OpenJDK 2D-Dev] RFR: 8022447 Fix doclint warnings in java.awt.image

2013-08-06 Thread Joe Darcy
On 08/06/2013 02:53 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8022447/ Hi Phil, Looks good; approved to go back. Thanks, -Joe

Re: [OpenJDK 2D-Dev] RFR: 8022455 : Fix doclint warnings in javax.imageio

2013-08-06 Thread Joe Darcy
On 08/06/2013 04:24 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8022455/ -phil Hi Phil, Looks good; approved to go back. Thanks, -Joe

Re: [OpenJDK 2D-Dev] RFR: 8022175 Fix doclint warnings in javax.print

2013-08-06 Thread Joe Darcy
On 08/06/2013 01:00 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8022175/ Fixed lots of complaints about nested ../ and malformed HTML due to < & > chars plus a few other things. Hi Phil, Looks good; approved to go back. Thanks, -Joe

Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

2013-06-05 Thread Joe Darcy
I don't think it is tenable to have long-term maintenance of two build systems. Any remaining blockers in the new build should be addressed so the old build can be put out to pasture. -Joe On 6/5/2013 1:50 PM, Phil Race wrote: Heavens no. Its a blessing. I sometimes do development work in 7 b

Re: [OpenJDK 2D-Dev] FileCacheImageOutputStream.close() is not idempotent

2012-06-19 Thread Joe Darcy
On 6/14/2012 10:37 AM, Phil Race wrote: On 6/14/2012 10:09 AM, Martin Desruisseaux wrote: Le 14/06/12 18:59, Phil Race a écrit : Perhaps the real issue is that the interface Closeable should not have made claims about what all the existing close methods it was added to do in all cases. FileIn

Re: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-05-04 Thread Joe Darcy
On 05/04/10 06:28 PM, Martin Buchholz wrote: On Tue, May 4, 2010 at 02:14, Roman Kennke wrote: I also have a testcase that triggers the problem pretty reliably (at least on my system). Problem is, it can't be 100% reliable, and it likely depends on system setup (i.e. fonts installed). Find t

Re: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-05-04 Thread joe . darcy
On 5/3/2010 6:35 PM, Martin Buchholz wrote: Hi Roman, I can confirm that your fix addresses the hang in my hacky test case FontDeadlock.java, so we at Google will use your fix for openjdk6, and would like to see it in openjdk6 proper. Joe, could you give this fix a thumbs up? Hmm. Is this

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files

2010-03-11 Thread Joe Darcy
Phil Race wrote: Andrew John Hughes wrote: . Can I have a bug ID to push this? I assume, given the list redirection, it wants to be in the 2d forest. Joe, is this also ok for 6? Bug ID is 6934327: Update linux fontconfigs for Ubuntu and Fedora. I am sure this is fine for 6 too .. Give

Re: [OpenJDK 2D-Dev] Request to backport fix for 6708392 to openjdk6

2009-09-14 Thread Joe Darcy
Andrew John Hughes wrote: 2009/9/11 Joseph D. Darcy : Hello. For fixes that have been soaking in JDK 7 for a while, there is a presumption of their validity. So by default I'm happy to have additional such fixes backported to OpenJDK 6, assuming the change is appropriate for the release, do

Re: [OpenJDK 2D-Dev] Code review request to integrate IcedTea Color.createContext fix into OpenJDK 6

2008-08-07 Thread Joe Darcy
se change it to follow. Thanks, Dmitri Joe Darcy wrote: Hello. Please review my application of the Color.createContext fix Keith previously sent to the list http://mail.openjdk.java.net/pipermail/2d-dev/2008-April/000252.html to OpenJDK 6. I've done a build and the JCK tests

[OpenJDK 2D-Dev] Code review request to integrate IcedTea Color.createContext fix into OpenJDK 6

2008-08-07 Thread Joe Darcy
Hello. Please review my application of the Color.createContext fix Keith previously sent to the list http://mail.openjdk.java.net/pipermail/2d-dev/2008-April/000252.html to OpenJDK 6. I've done a build and the JCK tests in question now pass. Webrev uploaded to: http://dcstaff.invokedynam