Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-25 Thread Prahalad Kumar Narayanan
y 25, 2018 3:23 PM To: Sergey Bylokhov; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay Kindly ignore the point mentioned below with ( >) when you follow-up. Lines 431 and 671 in

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-25 Thread Sergey Bylokhov
y 25, 2018 3:23 PM To: Sergey Bylokhov; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay Kindly ignore the point mentioned below with ( >) when you follow-up. Lines 431

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-25 Thread Jayathirth D V
-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay Kindly ignore the point mentioned below with ( >) when you follow-up. Lines 431 and 671 in webrev.01 are correct and we needn't change subt

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-25 Thread Prahalad Kumar Narayanan
2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay Sergey has suggested a valid point- If the CRC was generated with incorrect chunk data, the approach I suggested will succeed and we wou

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-24 Thread Prahalad Kumar Narayanan
Original Message- From: Sergey Bylokhov Sent: Thursday, January 25, 2018 5:44 AM To: Prahalad Kumar Narayanan; Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size On 22/01/2018 23:17, Prah

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-24 Thread Sergey Bylokhov
On 22/01/2018 23:17, Prahalad Kumar Narayanan wrote: My suggestion was to - . 'Generate' CRC from Chunk data and compare it with the retrieved value at Line 731 'before' proceeding to process any of the chunks. . In mal-formed chunks (corrupted chunk length /or chunk data), the CRC check will

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-22 Thread Prahalad Kumar Narayanan
anks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Tuesday, January 23, 2018 8:24 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay I looked

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-22 Thread Jayathirth D V
inal Message- From: Prahalad Kumar Narayanan Sent: Tuesday, January 23, 2018 8:24 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay I looked into the bug and the fix. The

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-22 Thread Prahalad Kumar Narayanan
ate CRC with data read from the stream and compare it against the CRC stored for the chunk to validate. Thank you Have a good day Prahalad N. - Original Message - From: Jayathirth D V Sent: Monday, January 22, 2018 4:20 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngRead

[OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

2018-01-22 Thread Jayathirth D V
Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8191023 Webrev : http://cr.openjdk.java.net/~jdv/8191023/webrev.00/ Note : Submitter has raised 3 bugs JDK-8191023 , JDK-8191076 , JDK-8191109 with similar issue but in 3 different