Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018-11-20 Thread Krishna Addepalli
+1 Thanks, Krishna -Original Message- From: Jayathirth D V Sent: Tuesday, November 20, 2018 1:59 PM To: 2d-dev <2d-dev@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458 Thanks Sergey for the

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018-11-20 Thread Jayathirth D V
is needed and > we are using band information from output image(having extra alpha channel) > on input image which has no alpha channel. Change in numBands logic for this > bug fixes that issue. > > > Thanks, > Jay > > -Original Message----- > From: Sergey Bylok

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018-11-16 Thread Sergey Bylokhov
Original Message- From: Jayathirth D V Sent: Wednesday, November 14, 2018 1:09 PM To: Sergey Bylokhov; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458 Hi Sergey, Thanks for the review. As you pointed out, yes th

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018-11-16 Thread Jayathirth D V
dnesday, November 14, 2018 1:09 PM To: Sergey Bylokhov; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458 Hi Sergey, Thanks for the review. As you pointed out, yes the AIOOB is happening for ps[b]. I have updated the anal

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018-11-13 Thread Sergey Bylokhov
Hi, Jay. Can you please provide some more detail about this bug. Root cause : In JDK-6788458 we are adding extra alpha channel for destination whenever we have tRNS chunk. But the number of bands in bitDepth scale array was not changed when we have tRNS chunk. This is causing

[OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018-11-13 Thread Jayathirth D V
Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8211795 Webrev: http://cr.openjdk.java.net/~jdv/8211795/webrev.00/ Issue : When we read PNG image having tRNS chunk and it needs bitDepth adjustment then we throw