Re: [OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism

2019-12-23 Thread Sergey Bylokhov
On 12/23/19 9:24 pm, Phil Race wrote: I assume you've run all the regression tests on macos just to make sure ?> Approved if the answer is yes. yes. Approved for 15 that is .. not 14. -phil. On 12/6/19 4:23 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug:

Re: [OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism

2019-12-23 Thread Phil Race
I assume you've run all the regression tests on macos just to make sure ? Approved if the answer is yes. Approved for 15 that is .. not 14. -phil. On 12/6/19 4:23 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8235520 Fix:

Re: [OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism

2019-12-19 Thread Jayathirth D v
Changes are fine. Thanks, Jay > On 07-Dec-2019, at 5:53 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8235520 > Fix: http://cr.openjdk.java.net/~serb/8235520/webrev.00 > > This is a part of the effort to clean

[OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism

2019-12-06 Thread Sergey Bylokhov
Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8235520 Fix: http://cr.openjdk.java.net/~serb/8235520/webrev.00 This is a part of the effort to clean up the macOS code, each new cleanup opens a new opportunity to delete some other code. During the early