Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

2020-04-16 Thread Jayathirth D v
Thanks for both the reviews. Yes embed link and it is going to wrong bug. Thanks for pointing to proper link. Regards, Jay > On 17-Apr-2020, at 3:21 AM, Philip Race wrote: > > +1 > > BTW your bug link goes to the wrong bug, should go here : > https://bugs.openjdk.java.net/browse/JDK-8195841

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

2020-04-16 Thread Philip Race
+1 BTW your bug link goes to the wrong bug, should go here : https://bugs.openjdk.java.net/browse/JDK-8195841 -phil. On 4/13/20, 2:40 AM, Jayathirth D v wrote: Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8195841

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

2020-04-14 Thread Sergey Bylokhov
Looks fine. On 4/13/20 2:40 am, Jayathirth D v wrote: Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 Webrev : http://cr.openjdk.java.net/~jdv/8195841/ Issue : PNGImageReader

[OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

2020-04-13 Thread Jayathirth D v
Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 Webrev : http://cr.openjdk.java.net/~jdv/8195841/ Issue : PNGImageReader doesn’t check