Re: [OpenJDK 2D-Dev] [9] 8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL

Hello, Brian On 11/15/2016 7:25 PM, Brian Burkhalter wrote: Hello Alexander, On Nov 15, 2016, at 4:11 AM, Alexander Stepanov > wrote: Thank you for the comments (hopefully I wasn't too confident picking the issue).

Re: [OpenJDK 2D-Dev] [9] 8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL

Hello Alexander, On Nov 15, 2016, at 4:11 AM, Alexander Stepanov wrote: > Thank you for the comments (hopefully I wasn't too confident picking the > issue). You’re welcome. I doubt that you will have any trouble with it. > Yes, from the "do not harm"

Re: [OpenJDK 2D-Dev] [9] 8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL

Hello Brian, Thank you for the comments (hopefully I wasn't too confident picking the issue). Yes, from the "do not harm" position it seems better to remove all the reduction-related fragments (leaving these worries to the user), but keep the zero denominator checks + the sign checks for

Re: [OpenJDK 2D-Dev] [9] 8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL

Hello Alexander, Thanks for picking up this issue. I actually worked on it a little last week as well but did not yet finish a patch. The TIFF 6.0 specification does not provide any guidance on the handling of rational values in terms of the three questions at hand: 1 - Should the rational

[OpenJDK 2D-Dev] [9] 8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL

P.S. please let me know if for some purposes the fractions should be stored in the initial (non-reduced) state. at a 1st glance it is not required, but maybe I'm wrong. If this is the case, then only some part of the changes should probably be applied: 1. remove needless reduction in

[OpenJDK 2D-Dev] [9] 8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8152293/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8152293 ? Thanks, Alexander