Hi All,
Please review a fix for jdk9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154057
webrev: http://cr.openjdk.java.net/~psadhukhan/8154057/webrev.00/
As per spec, Toolkit.getPrintJob() should throw NPE if null frame object
is passed to it.
But on macos, it seems getPrintJob() does not c
please resubmit this review request with the bug id in the subject line.
-phil.
On 04/12/2016 04:16 AM, prasanta sadhukhan wrote:
Hi All,
Please review a fix for jdk9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154057
webrev: http://cr.openjdk.java.net/~psadhukhan/8154057/webrev.00/
As pe
Sorry not this one
I meant a different review
:http://mail.openjdk.java.net/pipermail/2d-dev/2016-April/006670.html
-phil
On 04/12/2016 10:02 AM, Phil Race wrote:
please resubmit this review request with the bug id in the subject line.
-phil.
On 04/12/2016 04:16 AM, prasanta sadhukhan wro
hmm .. if it does not throw NPE when the dialog type is common that
could mean
that the code is not referencing the frame as a modal parent /owner in
that case which could
be another bug.
Did you check into how this is used relative to other platforms ?
-phil.
On 04/12/2016 04:16 AM, prasanta
Hi Phil,
Yes, it seems code does not use this frame as parent/owner.
Actually, xxxToolkit will call initPrintJob2D() after checking for
frame==null, followed by PrintJob2D.printDialog() which will just store
the frame in the attribute
if (frame != null) {
attributes.add(new Dialog
Ok, so +1 to this fix but file a new bug to track the non-usage of the
owner frame.
-phil.
On 4/13/16, 1:13 AM, prasanta sadhukhan wrote:
Hi Phil,
Yes, it seems code does not use this frame as parent/owner.
Actually, xxxToolkit will call initPrintJob2D() after checking for
frame==null, follo
Thanks for the review. I have filed a new issue for this non-usage of frame
https://bugs.openjdk.java.net/browse/JDK-8154218
Regards
Prasanta
On 4/13/2016 9:29 PM, Philip Race wrote:
Ok, so +1 to this fix but file a new bug to track the non-usage of the
owner frame.
-phil.
On 4/13/16, 1:13 AM
all platforms.
Thanks,
Jay
-Original Message-
From: prasanta sadhukhan
Sent: Thursday, April 14, 2016 11:00 AM
To: Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8154057, , [macosx] getPrintJob
doesn't throw NPE if Frame is null AND type is C
