It appears to me that this fix has caused a regression.
When I bring up this dialog (on Linux) Print To File is always greyed out.
I think somewhere along the line you became we concerned about whether
specific value should grey it out or not that it got lost that is no longer
possible to set
Hi Prasanta,
Since CUPS is not used in Windows, your change will not make difference if I
run the test in Windows.
Please add @requires tag in jtreg test case and there are some lines which are
80 character plus.
Also please add null check when you create PrinterService in test case.
Eh ? Before your change the code was calling
isAttributeCategorySupported(), notisAttributeValueSupported()
So there was not previously a possibility of that NPE, and
my point was now you have changed that call you need that !=null check
even more ..
But I think there is still a problem. Now
Hi Phil,
NPE will be thrown
--
public boolean isAttributeValueSupported(Attribute attr,
DocFlavor flavor,
AttributeSet attributes) {
if (attr == null) {
throw new
---
https://docs.oracle.com/javase/8/docs/api/javax/print/PrintService.html#isAttributeValueSupported-javax.print.attribute.Attribute-javax.print.DocFlavor-javax.print.attribute.AttributeSet-
Throws:
NullPointerException - (unchecked exception) if attrval is null.
--
So why did you remove
Hi All,
Please review a fix for an issue where it is seen that "Print-To-File"
option is enabled even for flavors that do not support Destination attribute
even though isAttributeValueSupported for that flavor returns false.
Bug: https://bugs.openjdk.java.net/browse/JDK-5049012
webrev:
