Hi Prasanta,
Changes are working fine along with 8061258 changes and test case is working
fine.
In test case there are some trailing white spaces, unused imports and lines
extending 80 character length. Please modify them before pushing.
Thanks,
Jay
-Original Message-
From: prasanta
Hi Phil,
Yes, the combination of this fix plus 8061258 works with both the
testcase I have along with the fix(es).
Jay, can you please review and give your +1 on this?
Regards
Prasanta
On 3/30/2016 12:13 AM, Phil Race wrote:
Like the related fix passing down page ranges to the dialog this
Like the related fix passing down page ranges to the dialog this looks
reasonable
but I have not had time to apply the patch and test it.
You should test the combination of this fix + that for 8061258 before
pushing ..
-phil.
On 03/22/2016 04:25 AM, prasanta sadhukhan wrote:
Hi Phil,
I
Hi Phil,
I have modified the webrev as per your review comment regarding 0-based
page indices that osx native supports.
http://cr.openjdk.java.net/~psadhukhan/8042713/webrev.01/
I have tested with copies and pageranges set with my testcase and also
Hi Phil,
Please review a fix for
bug: https://bugs.openjdk.java.net/browse/JDK-8042713
webrev: http://cr.openjdk.java.net/~psadhukhan/8042713/webrev.00/
The OS X platform print dialog has an option to set the page ranges.
If this is done it ought to be reported back in the AttributeSet.
but it
The bug report seems to be lacking a proper (any) evaluation.
It is probably not accurate to say it did not call the "correct" methods
since
the problem is actually that there was no method that did this and you
needed
to add them and make sure they also did what they in turn called what
