Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-02 Thread Phil Race
+1 -phil. On 09/02/2016 07:59 AM, Brian Burkhalter wrote: Here is a somewhat less inane version: http://cr.openjdk.java.net/~bpb/8154075/webrev.01/ All the same tests still pass. Thanks, Brian On Sep 1, 2016, at 1:37 PM, Brian Burkha

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-02 Thread Brian Burkhalter
Here is a somewhat less inane version: http://cr.openjdk.java.net/~bpb/8154075/webrev.01/ All the same tests still pass. Thanks, Brian On Sep 1, 2016, at 1:37 PM, Brian Burkhalter wrote: > I did not notice that. It is indeed bizarre. I was trying to take some > calculations outside the loo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-01 Thread Brian Burkhalter
I did not notice that. It is indeed bizarre. I was trying to take some calculations outside the loops to obtain a small performance improvement and did not notice the name transposition. I’ll update it. Thanks, Brian On Sep 1, 2016, at 1:27 PM, Phil Race wrote: > 168 int gain = s

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-01 Thread Phil Race
168 int gain = step * srcWidth; 169 int bound = srcWidth * step; This looks odd. Is it what you meant ? -phil. On 09/01/2016 08:57 AM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8154075 Patch: http:/

[OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-01 Thread Brian Burkhalter
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8154075 Patch: http://cr.openjdk.java.net/~bpb/8154075/webrev.00/ For banded images make sure the step in the horizontal differencing predictor calculations for Deflate and LZW compression is unity (1) instead o