Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

2016-08-02 Thread Jayathirth D V
Sent: Tuesday, August 02, 2016 12:12 AM To: Phil Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java +1 for the review with a preference for Vadim's suggestion. Brian On Aug 1, 2016, at 10:15 AM

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

2016-08-01 Thread Brian Burkhalter
+1 for the review with a preference for Vadim’s suggestion. Brian On Aug 1, 2016, at 10:15 AM, Phil Race wrote: > That would be fine too. The main thing was getting rid of Class.forName > > -phil. > > On 08/01/2016 10:19 AM, Vadim Pakhnushev wrote: >> Why not just

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

2016-08-01 Thread Phil Race
That would be fine too. The main thing was getting rid of Class.forName -phil. On 08/01/2016 10:19 AM, Vadim Pakhnushev wrote: Why not just registry.getServiceProviders(ImageReaderSpi.class, ? Vadim On 01.08.2016 19:13, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

2016-08-01 Thread Vadim Pakhnushev
Why not just registry.getServiceProviders(ImageReaderSpi.class, ? Vadim On 01.08.2016 19:13, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev :

[OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

2016-08-01 Thread Jayathirth D V
Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev.00/ Root Cause : KSS tool has detected usage of class.forName where it can be avoided. Solution : Use

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

2016-08-01 Thread Philip Race
+1 -phil On 8/1/16, 9:13 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev.00/