Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-07-02 Thread Sergey Bylokhov
On 03.07.15 1:28, Jim Graham wrote: If that is the new proper support matrix then the changes look good... Thanks! ...jim On 7/2/15 3:13 PM, Sergey Bylokhov wrote: On 03.07.15 0:55, Jim Graham wrote: One last thing. The old test in the SurfaceManagers used to only require FB_OB

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-07-02 Thread Jim Graham
In other words, we used to have: OPAQUE - use a PBUFFER, always accelerated BITMASK - not accelerated TRANSLUCENT - use FB if available, otherwise use a PBUFFER if CAPS_ALPHA, otherwise not accelerated Now we have: OPAQUE - use FB if available, otherwise not accelera

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-07-02 Thread Sergey Bylokhov
On 03.07.15 0:55, Jim Graham wrote: One last thing. The old test in the SurfaceManagers used to only require FB_OBJECT for translucent types, the new test requires FB_OBJECT for all types. Is that intentional? Yes, there was an assumption that pbuffers always support opaque types(translucen

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-07-02 Thread Jim Graham
One last thing. The old test in the SurfaceManagers used to only require FB_OBJECT for translucent types, the new test requires FB_OBJECT for all types. Is that intentional? ...jim On 7/2/15 1:04 PM, Sergey Bylokhov wrote: On 18.06.15 9:30, Jim Graham wrote: CGLVSM.

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-07-02 Thread Phil Race
+1 -phil. On 07/02/2015 01:04 PM, Sergey Bylokhov wrote: On 18.06.15 9:30, Jim Graham wrote: CGLVSM.java: In the constructor we claim to accelerate any surface if CAPS_EXT_FBOBJECT is present, but CGLGC.java has a test to reject BITMASK. Shouldn't the 2 perform the same test? Yes you are r

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-07-02 Thread Sergey Bylokhov
On 18.06.15 9:30, Jim Graham wrote: CGLVSM.java: In the constructor we claim to accelerate any surface if CAPS_EXT_FBOBJECT is present, but CGLGC.java has a test to reject BITMASK. Shouldn't the 2 perform the same test? Yes you are right. After additional investigation I found that we incor

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-06-29 Thread Jim Graham
On 6/29/2015 10:35 AM, Sergey Bylokhov wrote: Hi, Jim. Thanks for review! Thew new version of the fix: http://cr.openjdk.java.net/~serb/7188942/webrev.02 Comments about pbuffer were changed. CGLGC.java: In createCompatVM() I dislike separated tests for "here is early rejection of the list of

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-06-29 Thread Sergey Bylokhov
Hi, Jim. Thanks for review! Thew new version of the fix: http://cr.openjdk.java.net/~serb/7188942/webrev.02 Comments about pbuffer were changed. CGLGC.java: In createCompatVM() I dislike separated tests for "here is early rejection of the list of things that I can handle" followed by a list

Re: [OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-06-17 Thread Jim Graham
Hi Sergey, CGLGC.java: In createCompatVM() I dislike separated tests for "here is early rejection of the list of things that I can handle" followed by a list of tests for things it can handle. For one thing we have to test the type more than once. But mainly it just seems like the two tests

[OpenJDK 2D-Dev] [9] Review Request: 7188942 Remove support of pbuffers in OGL Java2d pipeline

2015-06-16 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. The reason of the removing is a general deprecation of pbuffers, and a lack of their support in the java2d, because for a long time pbuffers were not used by default. Attempts to disable FBO(which are used by default), and enable the pbufferes will cause