Re: [OpenJDK 2D-Dev] [9] Review Request: 8061831 [OGL] "java.lang.InternalError: not implemented yet" during the blit of VI to VI in xor mode

2015-05-27 Thread Andrew Brygin
Hello Sergey, the fix looks fine to me. Thanks, Andrew On 5/22/2015 7:59 PM, Sergey Bylokhov wrote: On 21.05.15 22:59, Jim Graham wrote: I'm curious about bufferClip in the converter routine. Does that help? Since we clip when we blit back to the destination in the last line, we don't nec

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061831 [OGL] "java.lang.InternalError: not implemented yet" during the blit of VI to VI in xor mode

2015-05-22 Thread Sergey Bylokhov
On 21.05.15 22:59, Jim Graham wrote: I'm curious about bufferClip in the converter routine. Does that help? Since we clip when we blit back to the destination in the last line, we don't necessarily need to clip the intermediate operation. I suppose it could save time, but if it is a rect cli

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061831 [OGL] "java.lang.InternalError: not implemented yet" during the blit of VI to VI in xor mode

2015-05-21 Thread Jim Graham
Please use the same indentation as the surrounding constructions: 62 OGLSurfaceToSwBlit blitSurfaceToIntArgbPre = NN new OGLSurfaceToSwBlit(SurfaceType.IntArgbPre, NNOGLSurfaceData.PF_INT_ARGB_PRE); I'm curious about bufferClip in the

[OpenJDK 2D-Dev] [9] Review Request: 8061831 [OGL] "java.lang.InternalError: not implemented yet" during the blit of VI to VI in xor mode

2015-05-21 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. Our blits machinary in case of absent of direct/general blits will use the AnyBlit, which uses surface.getRaster method. This method is not implemented in OGL surfaces, so we must have some blit, which covers all possible combinations of source/destination