Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello, Anton. The fix looks good. Thanks. On 16.04.2014 18:32, Andrew Brygin wrote: Hello Anton, the fix looks fine to me. Thanks, Andrew On 4/16/2014 6:30 PM, anton nashatyrev wrote: Hello Andrew, you are right, the fix may be less relaxing but still conforming: if the height == 1

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello Anton, the fix looks fine to me. Thanks, Andrew On 4/16/2014 6:30 PM, anton nashatyrev wrote: Hello Andrew, you are right, the fix may be less relaxing but still conforming: if the height == 1, but the minY - sampleModelTranslateY > 0 the data buffer should still contain at le

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello Andrew, you are right, the fix may be less relaxing but still conforming: if the height == 1, but the minY - sampleModelTranslateY > 0 the data buffer should still contain at least one scanline. Below is the updated fix. I've also added explicit check for implicit (minY - samp

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello Anton, we probably should use '(minY + height) > 1' as a condition for the scanstride test, should not we? Otherwise, we are not taking into account the case when minY is greater than 0, and too big scanstride may be potentially dangerous. Thanks, Andrew On 4/10/2014 11:26 PM, anton

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello, could you please review a slightly update fix version (the regression test upgraded) fix: http://cr.openjdk.java.net/%7Eanashaty/8038000/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8038000 Jim, thanks for your in-depth analysis, the validation indeed doesn't look ideal

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello Jim, On 28.03.2014 3:25, Jim Graham wrote: Hi Anton, A lot of those tests seem out of whack in that they test related conditions, but not the exact condition itself. What we really want is for every index of the form: offset + y * scanlineStride + x + {0 -> numcomponents-1} => [0, b

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hi Anton, A lot of those tests seem out of whack in that they test related conditions, but not the exact condition itself. What we really want is for every index of the form: offset + y * scanlineStride + x + {0 -> numcomponents-1} => [0, buf.length-1] to be in the array for all valid x,y

[OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8038000/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8038000 The last row in the Raster shouldn't be necessary of the scanline