Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-03-16 Thread Sergey Bylokhov
Looks fine. Thank you for contribution! On 12/03/2019 23:38, Mikhail Filippov wrote: I looking for the second reviewer and sponsor for my font patch: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.03/ -- Mikhail Filippov Software Developer JetBrains http://jetbrains.com “The Drive To Develo

Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-03-12 Thread Mikhail Filippov
I looking for the second reviewer and sponsor for my font patch: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.03/ -- Mikhail Filippov Software Developer JetBrains http://jetbrains.com “The Drive To Develop" > On 4 Mar 2019,

Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-03-04 Thread Mikhail Filippov
Webrev with line-length fix: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.03/ -- Mikhail Filippov Software Developer JetBrains http://jetbrains.com “The Drive To Develop" > On 28 Feb 2019, at 00:35, Phil Race wrote: > > I have made sure this builds OK and that it passes at least b

Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-02-27 Thread Phil Race
I have made sure this builds OK and that it passes at least basic tests. Line 514 is MUCH more than 80 chars. Please break it. Once you get a 2nd review, your sponsor can push it to jdk/client. -phil On 2/19/19 5:57 AM, Mikhail Filippov wrote: New webrev with fixes: http://cr.openjdk.java.net/

Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-02-19 Thread Mikhail Filippov
New webrev with fixes: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.02/ > On 15 Feb 2019, at 19:31, Phil Race wrote: > > > 8218914: Handle the case when fonts are installed into user registry key. > > This is the default behaviour since Windows 10 1809. > > When you get to the point of

Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-02-15 Thread Phil Race
>  8218914: Handle the case when fonts are installed into user registry key. This is the default behaviour since Windows 10 1809. When you get to the point of preparing a changeset, this line should have the bug synopsis. The text you have here is better placed on the "Summary:" line. You see

[OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-02-15 Thread Mikhail Filippov
Hi. Please review the fix. patch: attached to message.bug: https://bugs.openjdk.java.net/browse/JDK-8218914webrev: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.01/Description:Starting from Windows 10 Preview Build 17704 fonts are installed into the user's home folder by default, and are liste