Il 07/08/2009 22:01, Clemens Eisserer ha scritto:
>Ok now to push in?
Yes.
Cool - congratulations :)
- Clemens
Finally
Cheers,
Mario
> >Ok now to push in?
>
> Yes.
Cool - congratulations :)
- Clemens
>Ok now to push in?
Yes.
-phil.
Roman Kennke wrote:
Hi Phil,
6th round of the FontManager refactoring.
Can I assume you changed nothing except what you call out here ?
Yep.
In which case I'm fine except for one thing :
WPathGraphics.java
I see you moved the def
Hi Phil,
> > 6th round of the FontManager refactoring.
>
> Can I assume you changed nothing except what you call out here ?
Yep.
> In which case I'm fine except for one thing :
>
> >> WPathGraphics.java
> >>
> >> I see you moved the definition of textLayoutIsCompatible in here.
> >> Whilst its
Roman,
Roman Kennke wrote:
Hi there,
6th round of the FontManager refactoring.
Can I assume you changed nothing except what you call out here ?
In which case I'm fine except for one thing :
WPathGraphics.java
I see you moved the definition of textLayoutIsCompatible in here.
Whilst its use
Hi there,
6th round of the FontManager refactoring.
> you aren't using these import in sun.font.FontManager :
>30 import java.util.Locale;
>31 import java.util.TreeMap;
>32
>33 import javax.swing.plaf.FontUIResource;
>
> There may be other such cases but its easy to see in this m
Roman,
Looks close. Just a few comments.
you aren't using these import in sun.font.FontManager :
30 import java.util.Locale;
31 import java.util.TreeMap;
32
33 import javax.swing.plaf.FontUIResource;
There may be other such cases but its easy to see in this much reduced file.
SunGraph
Finally I got back (with some post JavaOne pushing from Phil) to merging
the newest stuff into my FontManager tree and here is the 5th revision
of the FontManager refactoring patch:
http://cr.openjdk.java.net/~rkennke/fontmanager/webrev.05/webrev/
I think I implemented all suggestions from previo
Roman Kennke wrote:
annels on that file get
closed before actually deleting the file. I don't know if it's
considered a bug in File.deleteOnExit() if it fails when any channels
are still open, I'd say yes, because cleaning up temporary files is what
this API is made for. Should not be so difficul
Hi Phil and everybody,
> > Ok, this makes sense now :-) Now I'm thinking that it's probably best to
> > go back to the original implementation, except that it's in
> > SunFontManager instead of FontManager. Do you agree?
> >
>
> Yes.
Ok, I changed it back to the original behaviour. I still th
Hi Phil,
> >> >> I'm not sure about the movement of addToPool() to TrueTypeFont.java
> >> >> Theoretically its independent of the font format, and could apply
> >> >> to any FileFont subclass.
> >> >> also the file closer shut down hook isn't needed except for created
> >> >> fonts from tmp f
Roman Kennke wrote:
Hi Phil,
>> I'm not sure about the movement of addToPool() to TrueTypeFont.java
>> Theoretically its independent of the font format, and could apply
>> to any FileFont subclass.
>> also the file closer shut down hook isn't needed except for created
>> fonts from tmp f
Hi Phil,
Here we go with another round:
> PhysicalFont.java : US_LCID better belongs in TrueTypeFont.java
> since you moved the only uses of it to that file.
Done.
> Since you are touching this, and so much else, maybe the following clean up
> too :
>
> sunFont.c :
>
> 74 /*
>75 * Cla
Hi Phil,
> I've only gone through maybe 35-40% of the changes but here's my comments
> so far :
>
> PhysicalFont.java : US_LCID better belongs in TrueTypeFont.java
> since you moved the only uses of it to that file.
Yeah right. I'll fix.
> Since you are touching this, and so much else, maybe th
Roman,
I've only gone through maybe 35-40% of the changes but here's my comments
so far :
PhysicalFont.java : US_LCID better belongs in TrueTypeFont.java
since you moved the only uses of it to that file.
Since you are touching this, and so much else, maybe the following clean up too
:
sunFont
Thanks Phil.
/Roman
Am Freitag, den 09.01.2009, 16:15 -0800 schrieb Phil Race:
>
> Roman Kennke wrote:
> > What's the status of this?
> >
>
> Its on my task list to review next week.
>
> -phil.
--
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks
Roman Kennke wrote:
What's the status of this?
Its on my task list to review next week.
-phil.
What's the status of this?
/Roman
Am Mittwoch, den 10.12.2008, 15:13 +0100 schrieb Roman Kennke:
> Hi Phil,
>
> I finally got around to fix up the font manager stuff. Some comments
> from me inline.
>
> > > this is the big FontManager refactoring patch I already mentioned a
> > > couple of ti
Hi Phil,
I finally got around to fix up the font manager stuff. Some comments
from me inline.
> > this is the big FontManager refactoring patch I already mentioned a
> > couple of times. It's primary purpose is to make the font implementation
> > more portable (or: portable at all), allowing a
Hi Phil,
> Some comments (at last) :
Thanks!
> > this is the big FontManager refactoring patch I already mentioned a
> > couple of times. It's primary purpose is to make the font implementation
> > more portable (or: portable at all), allowing alternative/derived
> > implementations to be pl
Some comments (at last) :
> this is the big FontManager refactoring patch I already mentioned a
> couple of times. It's primary purpose is to make the font implementation
> more portable (or: portable at all), allowing alternative/derived
> implementations to be plugged in. The general architectu
Hi,
> Wow, that's the large one. It will take some time for me to look through
> this
> and Phil is the right guy to review most of these changes anyway.
What is the status of the review?
/Roman
--
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks
Hi Igor,
> I see that in number of places static variables are upper case. E.g.
> number of variables in the FontUtilities.
> I am not sure if detailed naming and code conventions for OpenJDK were
> published but
> usually we use upper case names for constants only. See
> http://java.sun.com/d
Wow, that's the large one. It will take some time for me to look through
this
and Phil is the right guy to review most of these changes anyway.
Just few small comments for now.
I see that in number of places static variables are upper case. E.g.
number of variables in the FontUtilities.
I am n
Hi,
this is the big FontManager refactoring patch I already mentioned a
couple of times. It's primary purpose is to make the font implementation
more portable (or: portable at all), allowing alternative/derived
implementations to be plugged in. The general architecture breaks down
as follows:
- F
25 matches
Mail list logo
