Hi Roman,
OK, I have finally integrated this fix (with
a couple of minor changes after internal
code review):
http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4af4867ed787
From the code review by Chris (should have CC-ed you in the
first place):
>> SMF.java
>> 49: Take out the "Unix"
Hi Roman,
Roman Kennke wrote:
I can tell that someone didn't build on windows
since the build fails there =) The fix should have deleted
src/windows/classes/sun/java2d/SurfaceManagerFactory.java
just like it did the solaris/ one.
Whoops, did I forget that? I was sure I deleted i
Hi Dmitri,
> OK, I've submitted the bug (6675596) and applied the
>fix, and in the process of testing it.
Great, thanks!
>I can tell that someone didn't build on windows
>since the build fails there =) The fix should have deleted
>src/windows/classes/sun/java2d/SurfaceManagerFact
OK, I've submitted the bug (6675596) and applied the
fix, and in the process of testing it.
I can tell that someone didn't build on windows
since the build fails there =) The fix should have deleted
src/windows/classes/sun/java2d/SurfaceManagerFactory.java
just like it did the solari
Roman, I'm sorry, I'm completely swamped with a high
priority bug. I'll try to file a bug and a code review
tomorrow.
Dmitri
Roman Kennke wrote:
Hi,
This makes sense, because BufImgVolatileSurfaceManager is required for
all targets.
Yep, you're right, that should cover it.
I
Hi,
> > This makes sense, because BufImgVolatileSurfaceManager is required for
> > all targets.
>
>Yep, you're right, that should cover it.
>
>I'd wait for another reviewer and if there are no
>objections we could integrate it.
Any progress on this one?
Cheers, Roman
--
Dipl.-Inf
Roman Kennke wrote:
This makes sense, because BufImgVolatileSurfaceManager is required for
all targets.
Yep, you're right, that should cover it.
I'd wait for another reviewer and if there are no
objections we could integrate it.
Thanks,
Dmitri
Hi Dmitri,
>the change looks mostly fine to me.
Good!
>One thing - have you tested your change with the
>headless toolkit?
I haven't tested it, but it appears that in the headless case the
factory is never used anyway (from SunVolatileImage):
protected VolatileSurfaceManager cr
Hi Roman,
the change looks mostly fine to me.
One thing - have you tested your change with the
headless toolkit?
Because it has its own GraphicsEnvironment class,
and it would appear that you'd need to set appropriate
SMF in there too.
Now what would that "appropriate SMF" be
Hello,
I'm implementing a Java2D backend based on Escher, which is already
working quite well (for a couple-of-hours-prototype):
http://kennke.org/blog/2008/02/25/escher-on-openjdk-graphics/
One issue I came over is the SurfaceManagerFactory. There seems to be
such a factory class both in the so
10 matches
Mail list logo
