Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-09 Thread Sergey Bylokhov
09, 2018 12:41 AM To: Jayathirth D V; Philip Race; Brian Burkhalter Cc: awt-...@openjdk.java.net; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF Hi, Jay. So you leaved the code which checks the full color including alpha, b

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-09 Thread Jayathirth D V
n Burkhalter Cc: awt-...@openjdk.java.net; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF Hi, Jay. So you leaved the code which checks the full color including alpha, but the source image does not have an alpha so the ch

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-08 Thread Sergey Bylokhov
ebrev.02/ Thanks, Jay *From:*Philip Race *Sent:* Thursday, November 08, 2018 6:05 AM *To:* Brian Burkhalter *Cc:* awt-...@openjdk.java.net; 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF Right. It supports al

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-08 Thread Jayathirth D V
jdk.java.net/~jdv/8176556/webrev.02/ Thanks, Jay From: Philip Race Sent: Thursday, November 08, 2018 6:05 AM To: Brian Burkhalter Cc: awt-...@openjdk.java.net; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for J

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Philip Race
I think Jay's point is that the test isn't at all about alpha, so he chose to fix it by removing alpha which is equally as valid as switching format. -phil. On 11/7/18, 11:17 AM, Sergey Bylokhov wrote: Hi, Jay. As far as I understand the "png" still support alpha, and it is tested by this test

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Philip Race
Right. It supports alpha of 0 and 255, but nothing in between :-) -phil. On 11/7/18, 12:41 PM, Brian Burkhalter wrote: GIF 89a supports a transparent color index in the palette. Brian On Nov 7, 2018, at 11:25 AM, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: On more question a

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Brian Burkhalter
GIF 89a supports a transparent color index in the palette. Brian > On Nov 7, 2018, at 11:25 AM, Sergey Bylokhov > wrote: > > On more question about "image/gif" format, as far as I understand this format > do not support the alpha as well, then why it works w/o exceptions?

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Sergey Bylokhov
On more question about "image/gif" format, as far as I understand this format do not support the alpha as well, then why it works w/o exceptions? On 07/11/2018 11:17, Sergey Bylokhov wrote: Hi, Jay. As far as I understand the "png" still support alpha, and it is tested by this test? On 07/11/2

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Sergey Bylokhov
Hi, Jay. As far as I understand the "png" still support alpha, and it is tested by this test? On 07/11/2018 02:11, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176556 Webrev : http://cr.openjdk.java.net/~jdv/81765

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Jayathirth D V
: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF Hello All, Please review the following fix in JDK12 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176556 Webrev : http://cr.openjdk.java.net/~jdv/8176556/webrev.00/ Issue

[OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

2018-11-07 Thread Jayathirth D V
Hello All, Please review the following fix in JDK12 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176556 Webrev : http://cr.openjdk.java.net/~jdv/8176556/webrev.00/ Issue : When we run java/awt/dnd/ImageTransferTest/ImageTransferTest.java if fails to get ImageWriter(Service prov