Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

2016-07-22 Thread Lindenmaier, Goetz
regards, Goetz. > -Original Message- > From: Vadim Pakhnushev [mailto:vadim.pakhnus...@oracle.com] > Sent: Friday, July 22, 2016 9:09 AM > To: Phil Race ; Lindenmaier, Goetz > > Subject: Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory > issues. > > I'

Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

2016-07-20 Thread Vadim Pakhnushev
Hi Goetz, Maybe instead of increasing the stack size we could move the increment from the assignment to the previous if statement where we check for the overwrite possibility? There are similar code patterns in this file. Also there is almost identical file LigatureSubstProc.cpp which also co

[OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

2016-07-20 Thread Lindenmaier, Goetz
Hi This changes fixes two memory issues. In awt_PrintControl.cpp, a wrong pointer is freed. In LigatureSubstProc2.cpp, line 157: stack[++mm] = componentGlyph; can overwrite the stack by one element. It will write stack[nComponents], because ++mm increments before accessing the array. Fix: i