[OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-05 Thread Jayathirth D v
Hello All, _Please review following fix in jdk9:_ _Bug:_ https://bugs.openjdk.java.net/browse/JDK-8066904/ _Webrev:_ http://cr.openjdk.java.net/~rchamyal/jay/8066904/webrev.00/ _Bug:_ NullPointerException when calling ImageIO.re

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-05 Thread Sergey Bylokhov
Hi, Jay. The fix looks fine to me. On 05.10.15 13:17, Jayathirth D v wrote: Hello All, _Please review following fix in jdk9:_ _Bug:_ https://bugs.openjdk.java.net/browse/JDK-8066904/ _Webrev:_ http://cr.openjdk.java.net/~rchamyal/

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-05 Thread Jayathirth D v
Hi Sergey, Thanks for review. Hello All, I need one more review for this patch. Please review. Thanks, Jay On 10/5/2015 7:01 PM, Sergey Bylokhov wrote: Hi, Jay. The fix looks fine to me. On 05.10.15 13:17, Jayathirth D v wrote: Hello All, _Please review following fix in jdk9:_ _Bug:_ htt

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-06 Thread Jayathirth D v
Hello All, We noticed that jtreg tag "@run" was not matching main class name for test file. So made relevant change only in comment's section of test file. Please find updated Webrev link : http://cr.openjdk.java.net/~rchamyal/jay/8066904/webrev.01/ Thanks, Jay On 10/6/2015 9:51 AM, Jaya

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-07 Thread Jayathirth D v
Hello All, Gentle Reminder. Please review the changes. Thanks, Jay On 10/6/2015 12:57 PM, Jayathirth D v wrote: Hello All, We noticed that jtreg tag "@run" was not matching main class name for test file. So made relevant change only in comment's section of test file. Please find updated We

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-09 Thread Sergey Bylokhov
The new version still looks fine. On 07.10.15 12:24, Jayathirth D v wrote: Hello All, Gentle Reminder. Please review the changes. Thanks, Jay On 10/6/2015 12:57 PM, Jayathirth D v wrote: Hello All, We noticed that jtreg tag "@run" was not matching main class name for test file. So made rele

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

2015-10-09 Thread Phil Race
Approved -Phil. > On Oct 9, 2015, at 9:08 AM, Sergey Bylokhov > wrote: > > The new version still looks fine. > >> On 07.10.15 12:24, Jayathirth D v wrote: >> Hello All, >> >> Gentle Reminder. Please review the changes. >> >> Thanks, >> Jay >> >>> On 10/6/2015 12:57 PM, Jayathirth D v wrote