Re: [OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

2014-05-08 Thread Omair Majid
* Anthony Petrov [2014-05-05 10:12]: > The fix looks good to me, too. Thanks. I have pushed it: http://hg.openjdk.java.net/jdk9/client/jdk/rev/8b9bbe3b2e83 Regards, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681

Re: [OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

2014-05-05 Thread Anthony Petrov
The fix looks good to me, too. -- best regards, Anthony On 5/1/2014 1:19 AM, Phil Race wrote: Trying again with awt as "To:" rather than bcc: .. -phil. On 4/30/2014 2:12 PM, Phil Race wrote: Looks OK to me, but adding awt-dev as splashscreen is owned by AWT. -phil. On 4/30/2014 1:48 PM, Om

Re: [OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

2014-04-30 Thread Phil Race
Trying again with awt as "To:" rather than bcc: .. -phil. On 4/30/2014 2:12 PM, Phil Race wrote: Looks OK to me, but adding awt-dev as splashscreen is owned by AWT. -phil. On 4/30/2014 1:48 PM, Omair Majid wrote: Hi, As indicated in the libjpeg API documentation [1], the standard libjpeg he

Re: [OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

2014-04-30 Thread Phil Race
Looks OK to me, but adding awt-dev as splashscreen is owned by AWT. -phil. On 4/30/2014 1:48 PM, Omair Majid wrote: Hi, As indicated in the libjpeg API documentation [1], the standard libjpeg headers are: jpeglib.h, jerror.h, jconfig.h, jmorecfg.h. splashscreen_jpeg.c violates this layering a

[OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

2014-04-30 Thread Omair Majid
Hi, As indicated in the libjpeg API documentation [1], the standard libjpeg headers are: jpeglib.h, jerror.h, jconfig.h, jmorecfg.h. splashscreen_jpeg.c violates this layering and uses the SIZEOF macro from the non-public header jinclude.h directly. This macro is a wrapper over sizeof. The code i