On 26.01.2014 13:30, Alan Bateman wrote:
As a side point, client changes have been going into jdk9/client
rather than jdk9/dev so I just wonder if there might be changes backed
up in jdk9/client that might cause issues when merged.
It will be really good to push all fixes related to client to th
On 27/01/2014 19:52, Joe Darcy wrote:
:
Alan, I strongly prefer to limit this patch to just cast cleanup.
I understand, I was just pointing it out that some of these could use
for-each and that would also eliminate the cast.
:
Based on the results of an exploratory jprt job, listed below
On 01/27/2014 12:04 AM, Alan Bateman wrote:
On 26/01/2014 09:30, Alan Bateman wrote:
The only non-client changes that I see are to Setup.gmk (previously
reviewed on build-dev) and Sdp.java.
I see the others now, just hard to spot in a large mind-numbing patch :-)
All looks good but as I look a
Hello Joe,
the 'javax.imageio' part of the fix looks fine to me.
Thanks,
Andrew
On 1/25/2014 11:10 PM, Joe Darcy wrote:
Hello,
Please review my large, but largely straightforward, changes to fix
JDK-8032733: Fix cast lint warnings in client libraries
http://cr.openjdk.java.net/~darc
On 26/01/2014 09:30, Alan Bateman wrote:
The only non-client changes that I see are to Setup.gmk (previously
reviewed on build-dev) and Sdp.java.
I see the others now, just hard to spot in a large mind-numbing patch :-)
All looks good but as I look at this again then I see a few Iterator
usage
On 25/01/2014 19:10, Joe Darcy wrote:
Hello,
Please review my large, but largely straightforward, changes to fix
JDK-8032733: Fix cast lint warnings in client libraries
http://cr.openjdk.java.net/~darcy/8032733.0/
Many of the changes were enabled by the clone method of an array being
Hello,
Please review my large, but largely straightforward, changes to fix
JDK-8032733: Fix cast lint warnings in client libraries
http://cr.openjdk.java.net/~darcy/8032733.0/
Many of the changes were enabled by the clone method of an array being
redefined to return the array's type ra