On Wed, 17 Feb 2021 15:54:22 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Wed, 17 Feb 2021 15:54:22 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Wed, 17 Feb 2021 15:55:04 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> Marked as reviewed by aivanov (Reviewer).
Thanks @aivanov-jdk . Would you mind adding
On Wed, 17 Feb 2021 15:54:22 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Wed, 17 Feb 2021 15:48:12 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Wed, 17 Feb 2021 15:38:10 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Wed, 17 Feb 2021 15:25:35 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1206:
>
>> 1204: * with
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Wed, 17 Feb 2021 15:08:58 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Wed, 17 Feb 2021 14:20:47 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javdoc tag for NPE
>
> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1205:
>
>> 1203: *
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Mon, 15 Feb 2021 12:48:01 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Mon, 15 Feb 2021 12:44:28 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Fri, 12 Feb 2021 14:42:30 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix. Test updated
>
> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1204:
>
>>
On Tue, 9 Feb 2021 11:57:44 GMT, Prasanta Sadhukhan
wrote:
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
>
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Thu, 11 Feb 2021 15:44:57 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Thu, 11 Feb 2021 04:14:54 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Wed, 10 Feb 2021 18:46:33 GMT, Phil Race wrote:
>> From what I can tell, if clip is null, then calling clip(null) has no effect.
>> And it won't throw an NPE in that case. So the proposed documentation is
>> less accurate than no documentation at all.
>> And I would shy away from changing
On Wed, 10 Feb 2021 18:30:18 GMT, Phil Race wrote:
>> As per code
>> public void setClip(Shape sh) {
>> usrClip = transformShape(sh);
>>
>> usrClip is set to null if "sh" is null so clip is cleared...I will update
>> the setClip doc too..
>
> From what I can tell, if clip is null,
On Wed, 10 Feb 2021 06:01:59 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Wed, 10 Feb 2021 04:51:33 GMT, Prasanta Sadhukhan
wrote:
>> If "*setClip*(null)" has to clear the clip then it should be specified,
>> currently, that method said nothing about the null parameter.
>
> As per code
> public void setClip(Shape sh) {
> usrClip = transformShape(sh);
>
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it
On Wed, 10 Feb 2021 04:47:05 GMT, Sergey Bylokhov wrote:
>> I am not sure if it's implementation bug. As Jim Graham has mentioned in
>> thebug,
>>
>>> clip(null) is not legal.
>>>
>>> It is *setClip*(null) that clears the clip.
>> I could rephrase the doc to specify NPE willbe thrrown for
On Wed, 10 Feb 2021 04:26:17 GMT, Prasanta Sadhukhan
wrote:
>> Looks like this is just a bug in the implementation, the null should reset
>> the clip.
>
> I am not sure if it's implementation bug. As Jim Graham has mentioned in
> thebug,
>
>> clip(null) is not legal.
>>
>> It is
On Tue, 9 Feb 2021 18:10:44 GMT, Sergey Bylokhov wrote:
>>> Also, if there is no clip set, then the spec statement " If s is null, this
>>> method clears the current Clip" does not carry any meaning, so in both
>>> regard, setClip() should be there, I presume.
>>
>> The old javadoc is
On Tue, 9 Feb 2021 13:59:32 GMT, Alexander Zvegintsev
wrote:
>> @prsadhuk At first glance i also thought clip() should be called after
>> calling setClip() but that is not the case.
>>
>> If we see SunGraphics2D implementation of clip() we dont exit if there is no
>> clip(usrClip object) is
On Tue, 9 Feb 2021 13:13:51 GMT, Jayathirth D V wrote:
>> Also, if there is no clip set, then the spec statement " If s is null, this
>> method clears the current Clip" does not carry any meaning, so in both
>> regard, setClip() should be there, I presume.
>
> @prsadhuk At first glance i also
On Tue, 9 Feb 2021 12:54:26 GMT, Prasanta Sadhukhan
wrote:
>> The spec says "s - the Shape to be intersected with the current Clip" so I
>> assume it means there should be a current clip set, so that is why I have
>> used setClip to "set" a clip. So, setClip() should be there as far I see.
>
On Tue, 9 Feb 2021 12:52:55 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1206:
>>
>>> 1204: * @param s the {@code Shape} to be intersected with the current
>>> 1205: * {@code Clip}.
>>> 1206: * @throws
On Tue, 9 Feb 2021 12:48:44 GMT, Alexander Zvegintsev
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Tue, 9 Feb 2021 11:57:44 GMT, Prasanta Sadhukhan
wrote:
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
>
The API doc for Graphics2D.clip(shape s) claims that passing a null argument
would actually clear the existing clipping area, which is incorrect.
This statement is applicable only to G2D.setClip() and not for the clip()
method. G2D.clip() would throw a NullPointerException when it encounters a
38 matches
Mail list logo
