Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-28 Thread Sergey Bylokhov
On 27.08.2020 12:55, Philip Race wrote: SAP or IBM can look at it if they want as a separate fix. ok, +1 -phil. On 8/27/20, 12:45 PM, Sergey Bylokhov wrote: Hi, Phil. Probably we could enable WARNINGS_AS_ERRORS_xlc as well? I guess we will need a confirmation from the SAP gurus. On 27.

Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-28 Thread Magnus Ihse Bursie
On 2020-08-27 21:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html Looks good to me. Thank you Phil for cleaning this up! /Magnus This resolves the disabled compiler warnings in what is now quite a sm

Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Erik Joelsson
Build change looks good. /Erik On 2020-08-27 12:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves the disabled compiler warnings in what is now quite a small fontmanager library. I've built

Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Philip Race
I left that alone on purpose. I have no way of testing it and whereas for the 32 bit linux case I had an idea of what to fix, for xlc all I could find was it came in with https://bugs.openjdk.java.net/browse/JDK-8154087 and I've no idea what the problems were. SAP or IBM can look at it if they

Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Sergey Bylokhov
Hi, Phil. Probably we could enable WARNINGS_AS_ERRORS_xlc as well? I guess we will need a confirmation from the SAP gurus. On 27.08.2020 12:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves t

[OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Philip Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves the disabled compiler warnings in what is now quite a small fontmanager library. I've built windows, mac and linux in our build system and run our full battery of a