Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

2016-10-17 Thread Philip Race
On 10/17/16, 5:32 AM, Sergey Bylokhov wrote: Looks fine. I am not only sure about the difference in the variable names: "name" VS "face". Our code - and API - tends to use "name" or "full name" -phil. On 16.10.16 22:02, Vadim Pakhnushev wrote: I guess you could reorder the calls for

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

2016-10-17 Thread Philip Race
Harmless either way but I have committed as you suggest. -phil. On 10/16/16, 12:02 PM, Vadim Pakhnushev wrote: I guess you could reorder the calls for CFRelease(font); and CFRelease(desc); so the desc gets released first in two locations under family == NULL and name == NULL. Just for the

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

2016-10-17 Thread Sergey Bylokhov
Looks fine. I am not only sure about the difference in the variable names: "name" VS "face". On 16.10.16 22:02, Vadim Pakhnushev wrote: I guess you could reorder the calls for CFRelease(font); and CFRelease(desc); so the desc gets released first in two locations under family == NULL and name

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

2016-10-16 Thread Vadim Pakhnushev
I guess you could reorder the calls for CFRelease(font); and CFRelease(desc); so the desc gets released first in two locations under family == NULL and name == NULL. Just for the sake of consistency. Other than that, +1. Vadim On 16.10.2016 19:09, Philip Race wrote: Anyone ? I'd like to get

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

2016-10-16 Thread Philip Race
Anyone ? I'd like to get this backported to 8u this week so it can the 8u122 release which will enter RDP2 soon http://openjdk.java.net/projects/jdk8u/releases/8u122.html Although I have failed to find any email documenting the exact date the freeze is usually a week earlier than the RDP date

[OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

2016-10-12 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8089573 Webrev : http://cr.openjdk.java.net/~prr/8089573/ See the bug for some images showing the problem of scrambled text when printing. Although only JavaFX is affected the solution is entirely on the JDK side. JavaFX looks up some UI "system"