Re: [OpenJDK 2D-Dev] RFR: 8134986: Incorrect use of ConcurrentHashMap.contains in SunFontManager.java

2016-04-14 Thread Jennifer Godinez
Looks good. Jennifer On 04/04/2016 03:33 PM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8134986 When converted from a HashSet to a HashMap contains() should have changed to containsKey(). It does not lead to duplicate fonts because it is caught later on but it might lead to

Re: [OpenJDK 2D-Dev] RFR: 8134986: Incorrect use of ConcurrentHashMap.contains in SunFontManager.java

2016-04-06 Thread Sergey Bylokhov
Looks fine. On 05.04.16 1:33, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8134986 When converted from a HashSet to a HashMap contains() should have changed to containsKey(). It does not lead to duplicate fonts because it is caught later on but it might lead to wasted work One

[OpenJDK 2D-Dev] RFR: 8134986: Incorrect use of ConcurrentHashMap.contains in SunFontManager.java

2016-04-04 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8134986 When converted from a HashSet to a HashMap contains() should have changed to containsKey(). It does not lead to duplicate fonts because it is caught later on but it might lead to wasted work One line fix in line below diff --git