Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Hello Sergey, Semyon, Thanks! Regards, Alexander On 1/22/2016 9:54 AM, Semyon Sadetsky wrote: Looks good to me. --Semyon On 1/19/2016 7:17 PM, Alexander Stepanov wrote: Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Regards,

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Looks good to me. --Semyon On 1/19/2016 7:17 PM, Alexander Stepanov wrote: Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Regards, Alexander On 1/18/2016 5:12 PM, Sergey Bylokhov wrote: On 15/01/16 15:27, Alexander Stepanov wr

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

On 19/01/16 19:17, Alexander Stepanov wrote: Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Looks fine, please update JDK-8147448 that the this test should be updated after the fix. Regards, Alexander On 1/18/2016 5:12 PM,

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

P.S. 'biGrayTypes' in BitDepth.java was commented as the color checks used in the test are improper in case of graycsale images. On 1/19/2016 7:17 PM, Alexander Stepanov wrote: Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Rega

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Regards, Alexander On 1/18/2016 5:12 PM, Sergey Bylokhov wrote: On 15/01/16 15:27, Alexander Stepanov wrote: Hello Sergey, > Why this test do not cover the gif/bmp as well? I can

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

On 15/01/16 15:27, Alexander Stepanov wrote: Hello Sergey, > Why this test do not cover the gif/bmp as well? I can try to append the test, but it will fail for pair bmp + TYPE_INT_ARGB due to https://bugs.openjdk.java.net/browse/JDK-8147448 So we found a bug in jdk? I guess you can update the

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Hello Sergey, > Why this test do not cover the gif/bmp as well? I can try to append the test, but it will fail for pair bmp + TYPE_INT_ARGB due to https://bugs.openjdk.java.net/browse/JDK-8147448 Regards, Alexander On 1/12/2016 5:49 PM, Sergey Bylokhov wrote: Hi, Alexander. BitDepth.java the

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Hi, Alexander. BitDepth.java the @summary should be updated. Why this test do not cover the gif/bmp as well? It is unclear why biRGBATypes are unused in the test. On 12/01/16 17:40, Alexander Stepanov wrote: Please ignore mistaken changes in ImageWriterCompressionTest (re-uploading the webrev.

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Please ignore mistaken changes in ImageWriterCompressionTest (re-uploading the webrev...) Thanks, Alexander On 1/12/2016 5:28 PM, Alexander Stepanov wrote: Hello, Some imageio plugins reg. tests should probably be updated to reflect the fact that TIFF format is supported now. Could you ple

[OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Hello, Some imageio plugins reg. tests should probably be updated to reflect the fact that TIFF format is supported now. Could you please let me know if the following changes are appropriate? http://cr.openjdk.java.net/~avstepan/8146881/webrev.00/index.html (bug: https://bugs.openjdk.java.net/