On Fri, 30 Apr 2021 20:48:21 GMT, Alexey Ivanov wrote:
>> Getting smaller icon is relevant in the case of the scaling. I do not think
>> refactoring image caches from icons to multiresolution images will make code
>> much cleaner - at the end we will have to extract images from the
>> multires
> Fix updated after first round of review.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since the last revisi
On Fri, 30 Apr 2021 20:50:53 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64:
>>
>>> 62: }
>>> 63:
>>> 64: if (icon.getIconWidth() != size) {
>>
>> Does it make sense to check that the icon is a multi-resolution
On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pul
On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pul
On Tue, 11 May 2021 10:53:06 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> comm
On Tue, 11 May 2021 18:50:13 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1192:
>>
>>> 1190: */
>>> 1191: static Image getShell32Icon(int iconID, int size) {
>>> 1192: long hIcon = getIconResource("shell32.dll", ico
On Tue, 11 May 2021 18:48:31 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1196:
>>
>>> 1194: Image icon = makeIcon(hIcon);
>>> 1195: disposeIcon(hIcon);
>>> 1196: return icon;
>>
>> Shall it not
On Tue, 11 May 2021 10:07:30 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> comm
On Tue, 11 May 2021 20:01:37 GMT, Alexey Ivanov wrote:
>> Wherever it is necessary down the line we are wrapping the result in
>> multi-resolution and if we wrap it here too we will have multi-resolution
>> icon that contains multi-resolution images as a resolution variant.
>> Unfortunately AW
On Tue, 11 May 2021 19:36:12 GMT, Alexey Ivanov wrote:
>> I will create a separate bug to track this - i do not know if library
>> loading gets cached on some level and what impact on performance will we
>> have if we release it every call. But i will check it out separately.
>
> Sure! I just w
On Tue, 11 May 2021 21:34:59 GMT, Alexander Zuev wrote:
>> No, it isn't wrapped: if `getShell32Icon` is called in `getIcon(final
>> boolean getLargeIcon)`, the returned value is immediately returned to the
>> caller, see lines 1157–1163 in the updated code:
>>
>> if (hI
On Fri, 14 May 2021 13:41:31 GMT, Alexey Ivanov wrote:
>> I see - but still it has to be solved in the getShell32Icon method - which
>> i'm going to do in a moment.
>
> `Win32ShellFolder2.getSystemIcon` is still affected, the return value should
> be wrapped into MR-icon if its size is not equa
13 matches
Mail list logo
