Re: [OpenJDK 2D-Dev] RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]

2020-10-02 Thread Sergey Bylokhov
> We have a number of missing javadoc tags and comments in the desktop module. > Most of the missing comments are related to the serialized form. > > The fix: > - Adds missing comments to the non-static/non-transient fields(even > private) of the "serializable" classes > - Adds comments to th

Re: [OpenJDK 2D-Dev] RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]

2020-10-02 Thread Sergey Bylokhov
On Fri, 2 Oct 2020 19:46:10 GMT, Phil Race wrote: >> I think the main thing here is I would separate out removing the duplicate >> PeerFixer into a new bug. >> >> I also see that the CSR is still just a pure template. > >> I need advice about what exact change should be reviewed in the CSR(exce

Re: [OpenJDK 2D-Dev] RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]

2020-10-02 Thread Sergey Bylokhov
On Sat, 3 Oct 2020 03:57:21 GMT, Sergey Bylokhov wrote: >>> I need advice about what exact change should be reviewed in the CSR(except >>> PeerFixer removal) >> >> Probably almost all of it. > > The PeerFixer is extracted to the separate CR: > https://bugs.openjdk.java.net/browse/JDK-8253965 >

Re: [OpenJDK 2D-Dev] RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]

2020-10-03 Thread Phil Race
On Sat, 3 Oct 2020 00:31:48 GMT, Sergey Bylokhov wrote: >> We have a number of missing javadoc tags and comments in the desktop module. >> Most of the missing comments are related to the serialized form. >> >> The fix: >> - Adds missing comments to the non-static/non-transient fields(even >>