On Fri, 13 Aug 2021 14:28:53 GMT, Phil Race wrote:
>> But `getFontMetrics()` is the primary "entry point" that generated all the
>> JNI warnings in the first place. And I'm also not sure that we could've
>> gotten all the warnings on Windows without `JFrame`.
>
> So what's wrong with
>
On Thu, 12 Aug 2021 21:13:04 GMT, Phil Race wrote:
> passes
Looks good. I tried the test as headless and headful which happens to then
exercise a broader set of distros than only one or the other the way our
systems are set up.
-
PR: https://git.openjdk.java.net/jdk/pull/4572
On Fri, 13 Aug 2021 12:29:06 GMT, Maxim Kartashev
wrote:
>> oh you are getting metrics for a JFrame ? That's not going to exercise any
>> new font code so is pointless except to make it so the test has to be
>> headful.
>
> But `getFontMetrics()` is the primary "entry point" that generated
On Fri, 13 Aug 2021 00:07:56 GMT, Phil Race wrote:
>> test/jdk/java/awt/font/JNICheck/FreeTypeScalerJNICheck.java line 29:
>>
>>> 27: * @summary Verifies that -Xcheck:jni issues no warnings from
>>> freetypeScaler.c
>>> 28: * @library /test/lib
>>> 29: * @key headful
>>
>> What about this
On Thu, 12 Aug 2021 21:57:37 GMT, Phil Race wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed PR comments
>>
>> 1. Added CHECK_NULL() to awt_Component.cpp
>
>
On Thu, 12 Aug 2021 21:58:07 GMT, Phil Race wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed PR comments
>>
>> 1. Added CHECK_NULL() to awt_Component.cpp
>
>
On Mon, 19 Jul 2021 09:38:27 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need
On Mon, 19 Jul 2021 09:38:27 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need
On Mon, 19 Jul 2021 09:38:27 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need
