Re: [OpenJDK 2D-Dev] RFR: 8270893: IndexOutOfBoundsException while reading large TIFF file [v2]

2021-08-03 Thread Jayathirth D V
> We are incorrectly passing source offset to ImageInputStream.readFully() > which is getting used on destination buffer. streamPos maintained in each > implementation of stream maintain's appropriate source offset while reading > the data. Since we are completely utilizing destination buffer an

Re: [OpenJDK 2D-Dev] RFR: 8270893: IndexOutOfBoundsException while reading large TIFF file [v2]

2021-08-03 Thread Sergey Bylokhov
On Tue, 3 Aug 2021 09:11:07 GMT, Jayathirth D V wrote: >> We are incorrectly passing source offset to ImageInputStream.readFully() >> which is getting used on destination buffer. streamPos maintained in each >> implementation of stream maintain's appropriate source offset while reading >> the

Re: [OpenJDK 2D-Dev] RFR: 8270893: IndexOutOfBoundsException while reading large TIFF file [v2]

2021-08-04 Thread Jayathirth D V
On Tue, 3 Aug 2021 19:03:59 GMT, Sergey Bylokhov wrote: > Thank you! look fine. > BTW Looks like stream.readFully(unit, 0, sz) can be simplified to the > stream.readFully(unit)? Thanks for the review. Yes we can simplify readFully(), looks like we have other instances of similar usage of readF