[OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi, Please review this bug fix for the Marlin renderer to improve the array caches, its usages but also the renderer stats: bug: https://bugs.openjdk.java.net/browse/JDK-8159638 webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.0/ This patch also reduces slightly the memory footp

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Gentle reminder ... Jim, could you have a first look soon ? I am busy and will attend a conference next week, so maybe we could postpone the review in july. Laurent Le 15 juin 2016 11:10 PM, "Laurent Bourgès" a écrit : Hi, Please review this bug fix for the Marlin renderer to improve the arra

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Laurent, Some work should be done on the comments at the top of ArrayCache.java - line 38 and 42 make the same claim about 2 different thresholds. It seems silly, but in ArrayCache.getNewLargeSize(), lines 162 and 164 are both ">" tests and then the newly added test at 166 is a "<" test.

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Dear Jim, Thanks for your review, I'll answer your questions in the text below and will later propose a new webrev: 2016-07-19 9:00 GMT+02:00 Jim Graham : > > Some work should be done on the comments at the top of ArrayCache.java - > line 38 and 42 make the same claim about 2 different threshol

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Laurent, On 07/21/2016 06:56 AM, Laurent Bourgès wrote: I don't have any issues with those numbers, but the way that they are calculated makes it look like they are supposed to be unique numbers and yet through the obscurity of the loops used to populate the sizes they just en

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Jim, Here is an updated webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.1/ Changes: - merge Clean/Dirty Xxx ArrayCache using the flag 'clean' to indicate if the cache is clean or dirty + the putArray method always performs the array cleanup - ArrayCache renamed to ArrayCache

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Laurent, A tip on webrevs, if you supply a file of filenames then you can tell it to diff a file with a name change against its former name by using 2 filenames on the same line, as in: filetodiff1.java filetodiff2.java filetodiff3.java filetodiff3oldname.java filetodiff4.java ---

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Jim, A tip on webrevs, if you supply a file of filenames then you can tell it to > diff a file with a name change against its former name by using 2 filenames > on the same line, as in: > > > filetodiff1.java > filetodiff2.java > filetodiff3.java filetodiff3oldname.java > filetodiff4.j

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Thanks Laurent, On 08/02/2016 05:57 AM, Laurent Bourgès wrote: Thanks for the tip, I made another webrev (for archive) that shows the proper diffs in ArrayCache / ArrayCacheConst: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.1_bis/

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

I have not yet looked at everything but no issues except that I find checking in the shell script a bit weird. Not to mention its technically a "source file" so should have a license. -phil. On 8/2/16, 2:56 PM, Jim Graham wrote: Thanks Laurent, On 08/02/2016 05:57 AM, Laurent Bourgès wrote: T

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

How about instead of the shell script we put a comment up at the top of the files (after the copyright header), with the appropriate command line? Something like: /* * Note that the Byte/Int/Float files are nearly identical except * for a few type and name differences. Typically, the Byte v

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

I think that sounds reasonable. -Phil. > On Aug 2, 2016, at 5:28 PM, Jim Graham wrote: > > How about instead of the shell script we put a comment up at the top of the > files (after the copyright header), with the appropriate command line? > Something like: > > /* > * Note that the Byte/Int

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Jim & Phil, I added the following class header in Byte/Int/Float ArrayCache classes and removed the shell script: /* * Note that the [BYTE/INT/FLOAT]ArrayCache files are nearly identical except * for a few type and name differences. Typically, the [BYTE]ArrayCache.java file * is edited manuall

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

If that's the only change then it looks good to me... ...jim On 08/03/2016 02:58 AM, Laurent Bourgès wrote: Jim & Phil, I added the following class header in Byte/Int/Float ArrayCache classes and removed the shell script: /* * Note that the [BYTE/INT/FLOAT]ArrayCache

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Jim, Yes it is the only change. Phil, is it ok for you ? Thanks, Laurent Le 3 août 2016 8:56 PM, "Jim Graham" a écrit : > > If that's the only change then it looks good to me... > > ...jim

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

+1 -phil On 8/3/16, 12:14 PM, Laurent Bourgès wrote: Jim, Yes it is the only change. Phil, is it ok for you ? Thanks, Laurent Le 3 août 2016 8:56 PM, "Jim Graham" > a écrit : > > If that's the only change then it looks good to me... > >