Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

+1 -phil. On 7/26/20, 9:20 PM, Prasanta Sadhukhan wrote: Hi Phil, On 24-Jul-20 3:48 AM, Philip Race wrote: So the bug is that directly calling ServiceUI.printDialog() was enabling a non-functional properties button on just the Windows platform and you are adding an extra condition to

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Phil, On 24-Jul-20 3:48 AM, Philip Race wrote: So the bug is that directly calling ServiceUI.printDialog() was enabling a non-functional properties button on just the Windows platform and you are adding an extra condition to prevent that without harming the goal of JDK-4673406 to have it

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

So the bug is that directly calling ServiceUI.printDialog() was enabling a non-functional properties button on just the Windows platform and you are adding an extra condition to prevent that without harming the goal of JDK-4673406 to have it enabled and functional when invoked by

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Prasanta, I again tested updated webrev in Windows and Linux and it works as expected. webrev.1 looks good to me. Thanks, Jay > On 20-Jul-2020, at 8:45 PM, Prasanta Sadhukhan > wrote: > > Actually, I was a bit wrong in construing that the button should just be > disabled for

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Actually, I was a bit wrong in construing that the button should just be disabled for ServiceUI.printDialog if ServiceUIFactory is null & getUI(MAIN_ROLE...) is null. The "properties" dialog is used for another use-case which is for cross-platform dialog also ie, when we have a printer job

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Prasanta, Is just checking for dialog is null fine or we also need to verify DocumentProptiesUI in our case? As done in else case when dialog is null at http://hg.openjdk.java.net/jdk/client/file/fabf11c3a8ca/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l801

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Jay, I am using the same methodology used to determine whether to show the properties dialog when button-clicked on it (which is not to show if dialog is null) as per http://hg.openjdk.java.net/jdk/client/file/fabf11c3a8ca/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l793

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Prasanta, I tested the fix in Mac and Windows and it works as mentioned. In http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/windows/classes/sun/print/Win32PrintService.java#l1688

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Any reviewer for this? On 09-Jul-20 1:10 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where "Properties" button in ServiceUI.printDialog is enabled in windows but clicking it doesn't show any dialog. According to JDK-4673406

[OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi All, Please review a fix for an issue where "Properties" button in ServiceUI.printDialog is enabled in windows but clicking it doesn't show any dialog. According to JDK-4673406 , the properties dialog isn't supported for direct uses with