Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Verified, thanks a lot! - Jonathan 2012/3/22 Jonathan Lu > Verified > > Thanks, Charles! > > - Jonathan > > > 2012/3/22 Charles Lee > >> On 03/21/2012 04:17 PM, Jonathan Lu wrote: >> >>> Hi, the original patch was not rebased to the latest 2d code, here's the >>> rebased patch. >>> >>> http://

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

On 03/21/2012 04:17 PM, Jonathan Lu wrote: Hi, the original patch was not rebased to the latest 2d code, here's the rebased patch. http://cr.openjdk.java.net/~luchsh/7152519_2/jdk.patch Regards! - Jonathan On 03/21/2012 07:37 AM, Igor Nekrestyanov wrote: Looks fine to me. -igor On 3/20/12

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

still seem ok to me. -igor On 3/21/12 1:17 AM, Jonathan Lu wrote: Hi, the original patch was not rebased to the latest 2d code, here's the rebased patch. http://cr.openjdk.java.net/~luchsh/7152519_2/jdk.patch Regards! - Jonathan On 03/21/2012 07:37 AM, Igor Nekrestyanov wrote: Looks fine

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Hi, the original patch was not rebased to the latest 2d code, here's the rebased patch. http://cr.openjdk.java.net/~luchsh/7152519_2/jdk.patch Regards! - Jonathan On 03/21/2012 07:37 AM, Igor Nekrestyanov wrote: Looks fine to me. -igor On 3/20/12 3:30 PM, Phil Race wrote: I'm (still) OK w

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Thanks a lot, Phil and Igor. Regards! - Jonathan 2012/3/21 Igor Nekrestyanov > Looks fine to me. > > -igor > > > On 3/20/12 3:30 PM, Phil Race wrote: > >> I'm (still) OK with this .. one other reviewer please somebody. >> >> -phil. >> >> On 3/20/2012 1:37 AM, Jonathan Lu wrote: >> >>> Hello, c

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Looks fine to me. -igor On 3/20/12 3:30 PM, Phil Race wrote: I'm (still) OK with this .. one other reviewer please somebody. -phil. On 3/20/2012 1:37 AM, Jonathan Lu wrote: Hello, could anyone please help to take a look at this splitted patch? Thanks! -Jonathan 2012/3/13 Jonathan Lu

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

I'm (still) OK with this .. one other reviewer please somebody. -phil. On 3/20/2012 1:37 AM, Jonathan Lu wrote: Hello, could anyone please help to take a look at this splitted patch? Thanks! -Jonathan 2012/3/13 Jonathan Lu > Hi Phil, Thanks a lot

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Hello, could anyone please help to take a look at this splitted patch? Thanks! -Jonathan 2012/3/13 Jonathan Lu > Hi Phil, > > Thanks a lot for the review and testing, I've splited the patch into two > parts, one for 2D repository and another for TL. Here's the patch for 2D > repository: > > ht

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Hi Phil, Thanks a lot for the review and testing, I've splited the patch into two parts, one for 2D repository and another for TL. Here's the patch for 2D repository: http://cr.openjdk.java.net/~luchsh/7152519/ So could anybody please help to do another review? Thanks a lot! - Jonathan On

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

I added two of those includes myself I believe and I doubt I did it unless needed and others apparently found it necessary too. So we need to be sure this is OK. However at least one of those I added dates back to Solaris 8 being the build platform so maybe its no longer needed. I ran the patc

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

Bug 7152519 has been created for this patch. - Jonathan On 03/09/2012 07:49 PM, Jonathan Lu wrote: Hello 2d-dev, I find that link.h is included in several place of OpenJDK code, mostly together with dlfcn.h, but this caused portability problem in my testing on some Unix platforms, such as AI

[OpenJDK 2D-Dev] Remove including of link.h to improve portability

Hello 2d-dev, I find that link.h is included in several place of OpenJDK code, mostly together with dlfcn.h, but this caused portability problem in my testing on some Unix platforms, such as AIX. So far as I see OpenJDK only makes use of basic POSIX.1-2001 compatible dynamic library manipulation