Re: [OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-04 Thread Mark Reinhold
> Date: Thu, 04 Oct 2007 12:43:30 -0700 > From: [EMAIL PROTECTED] >Mark, when will the external access infrastructure be ready? If not at the time of the internal Mercurial cutover around the end of this month, then very shortly thereafter. - Mark

Re: [OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-04 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: Hi Dmitri, thanks for the patch. We're currently in a somewhat of a freeze because of the move to Mercurial, so we'll probably integrate the patch after that's done. Cool, thank you. I'll wait with more patches then until Mercurial is done. Will

Re: [OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-04 Thread Roman Kennke
Hi Dmitri, >thanks for the patch. > >We're currently in a somewhat of a freeze because of >the move to Mercurial, so we'll probably integrate the patch >after that's done. Cool, thank you. I'll wait with more patches then until Mercurial is done. Will we get read-access to the j2

Re: [OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-04 Thread Dmitri Trembovetski
Hi Roman, thanks for the patch. We're currently in a somewhat of a freeze because of the move to Mercurial, so we'll probably integrate the patch after that's done. Thanks, Dmitri Roman Kennke wrote: I looked through the classes in sun.java2d and removed most warnings there.

[OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-03 Thread Roman Kennke
I looked through the classes in sun.java2d and removed most warnings there. That is, unused imports, @Override annotations, local variables hiding fields, static field access through an instance, redundant casts and maybe something else I forgot. Find the patch attached. /Roman -- http://kennke

Re: [OpenJDK 2D-Dev] Remove warnings

2007-10-01 Thread Patrick Wright
FWIW, using Jackpot to clean up these sorts of simple problems seems like a good task to have around for people who want to get started sending in patches. Patrick

Re: [OpenJDK 2D-Dev] Remove warnings

2007-10-01 Thread Phil Race
Looks like the netbeans jackpot module can also be used for this : http://jackpot.netbeans.org/docs/transformer-module-tutorial.html#QueryDescription I don't think it matters if its an IDE as long as you can just press the "do it" button a small number of times. -phil. Ismael Juma wrote: Phil

Re: [OpenJDK 2D-Dev] Remove warnings

2007-09-27 Thread Ismael Juma
Phil Race <[EMAIL PROTECTED]> writes: > Most likely we could find thousands of such cases which pre-date > annotations. Does anyone know if there is a tool to (semi)automate this? You can use eclipse and the clean-up wizard (Source -> Clean-up) to do this and many other things (missing @Deprecated

Re: [OpenJDK 2D-Dev] Remove warnings

2007-09-27 Thread Roman Kennke
Hi Phil, > > - Access static fields like SunGraphics2D.XYZ rather than sg2d.XYZ. > > Better style generally and avoids potential programming error (rarely > > though). > > I suspect that this may have been a mixture of a personal stylistic > choice and keeping the line lengths shorter to avoid wr

Re: [OpenJDK 2D-Dev] Remove warnings

2007-09-27 Thread Phil Race
Hi, Roman Kennke wrote: Today I took some time studying the J2D code [1] and came across a bunch of warnings that I thought I'd remove (only in sun/java2d/x11 for now): - Remove unused imports, makes code slightly cleaner. Someone internally did a sweep recently looking for unused imports but

[OpenJDK 2D-Dev] Remove warnings

2007-09-25 Thread Roman Kennke
Today I took some time studying the J2D code [1] and came across a bunch of warnings that I thought I'd remove (only in sun/java2d/x11 for now): - Remove unused imports, makes code slightly cleaner. - Access static fields like SunGraphics2D.XYZ rather than sg2d.XYZ. Better style generally and avoi