Re: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-03-02 Thread Phil Race
I am OK too. -phil. On 2/25/2010 11:42 AM, Roman Kennke wrote: I just realized that there was another use of this field as sync lock, which I changed to use 'this' too. The lucidaFontName field is used in one other location (not for syncing) and it surely could use some cleanup, but I left it a

Re: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-02-25 Thread Igor Nekrestyanov
good catch. Lets wait for Phil to review. He knows this part of code better. -igor On 2/25/10 11:42 AM, Roman Kennke wrote: I just realized that there was another use of this field as sync lock, which I changed to use 'this' too. The lucidaFontName field is used in one other location (not for

Re: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-02-25 Thread Igor Nekrestyanov
i am ok with this fix. -igor On 2/25/10 7:19 AM, Roman Kennke wrote: Hi there, this patch fixes the deadlock in FontManager for OpenJDK7 that has been reported repeatedly on this list. I have a testcase here (attached), which I could prepare for jtreg, but it is not totally reliable and depend

Re: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-02-25 Thread Roman Kennke
I just realized that there was another use of this field as sync lock, which I changed to use 'this' too. The lucidaFontName field is used in one other location (not for syncing) and it surely could use some cleanup, but I left it alone for now. http://cr.openjdk.java.net/~rkennke/6892485/webrev.0

[OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

2010-02-25 Thread Roman Kennke
Hi there, this patch fixes the deadlock in FontManager for OpenJDK7 that has been reported repeatedly on this list. I have a testcase here (attached), which I could prepare for jtreg, but it is not totally reliable and depends on the system configuration (which and how many fonts installed), not s