Yes, I was wondering about that. I think I accidentally left that in there from
the original patch and didn't comment/remove it.
-- Scott
On Sep 6, 2012, at 5:04 PM, Mike Swingler wrote:
> Isn't this line a no-op, since you concat'ing the identity transform?
>
> + CGContextConcatCTM(qsdo->cgR
Isn't this line a no-op, since you concat'ing the identity transform?
+ CGContextConcatCTM(qsdo->cgRef, CGAffineTransformMake(1, 0, 0, 1, 0, 0));
Otherwise, looks fine.
Cheers,
Mike Swingler
Apple Inc.
On Sep 4, 2012, at 8:53 PM, Scott Kovatch wrote:
> I need one more reviewer/+1... anyone?
>
Looks ok to me.
-igor
On 9/4/12 8:27 AM, Scott Kovatch wrote:
(resending, now that I'm on 2d-dev.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applie
Approved.
-phil.
On 9/4/2012 8:27 AM, Scott Kovatch wrote:
(resending, now that I'm on 2d-dev.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applied.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applied.) before we draw the image. We have
already saved the state, but saving the state doesn't reset it.
(resending, now that I'm on 2d-dev.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applied.) before we draw the image. We have
already saved the state, b
On Aug 31, 2012, at 11:16 AM, Phil Race wrote:
> Scott,
>
> These files were added by Bino to support printing. Quartz isn't used
> except for printing in JDK 7, so as I understand it, testing on-screen in
> Java2Demo should not exercise this code. I'm surprised that you saw
> it being exercise
The recommendation is to restore the graphics state rather than inverting :-
https://developer.apple.com/library/mac/#documentation/graphicsimaging/conceptual/drawingwithquartz2d/dq_affine/dq_affine.html
"Quartz also provides an affine transform function that inverts a
matrix, |CGAffineTransfor
Scott,
These files were added by Bino to support printing. Quartz isn't used
except for printing in JDK 7, so as I understand it, testing on-screen in
Java2Demo should not exercise this code. I'm surprised that you saw
it being exercised. Did you do any printing testing ?
The matrix inversion se
