[OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail

2016-06-01 Thread Jayathirth D V
Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8152672 Webrev : http://cr.openjdk.java.net/~jdv/8152672/webrev.00/ Issue : When we are trying to get properties related to second image in JPEG file we are getting IIOException mentioning

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail

2016-06-01 Thread Jim Graham
I'm a little disturbed that we are just doing a basic "look for these byte value" type of search rather than parsing the file until we find an SOI. Are there cases where we are skipping arbitrary untagged data, or was this just lazy programming in the first place. Everything in a JPEG file shou

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail

2016-06-05 Thread Jayathirth D V
Hi Jim, When I verified by adding logs we are actually checking for EOI markers serially. I have sent detailed mail regarding the same in 2D-dev list. I don't think that we need brute force check of EOI/SOI markers continuously without parsing the header in this case of skipImage(). Thanks, Jay