Hi Sergey,
The fix looks fine to me.
--
best regards,
Anthony
On 05/13/13 19:24, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk 7u.
I send additional review request for jdk7, because there is a difference
in the fix from the version of jdk8.
Only one sensitive change is one line 1
Phil,
This is the command line that generates the crash:
-XX:DefaultMaxRAMFraction=8 -XX:+CreateMinidumpOnCrash -ea -esa
-XX:+TieredCompilation -XX:CompileThreshold=100
-XX:+UnlockExperimentalVMOptions -XX:-ShowMessageBoxOnError -Xverify:all
-XX:+CompileTheWorld -XX:CompileTheWorldStartAt=150
Hi,
Please review the fix for 8000936:
http://bugs.sun.com/view_bug.do?bug_id=8000936
http://cr.openjdk.java.net/~vadim/8000936/webrev.00/
The fix enables D3D pipeline on Intel graphic chipsets starting from GMA
4500 with recent drivers.
This was done in JavaFX a while ago.
In addition to copy
Phil, Andrew,
Would you please take a look at this updated fix posted half a year ago?
Thanks,
Vadim
On 20.11.2012 22:14, Vadim Pakhnushev wrote:
Phil,
That's right, interlaced images works as expected without the fix.
Non-interlaced images could be considered single pass but the
documentati
Looks good. Good to get this in now so there's plenty of time to find
any artifacts that haven't affected FX.
-phil.
On 5/16/2013 12:23 PM, Vadim Pakhnushev wrote:
Hi,
Please review the fix for 8000936:
http://bugs.sun.com/view_bug.do?bug_id=8000936
http://cr.openjdk.java.net/~vadim/8000936/we
Hi Vadim,
the fix looks fine to me.
Thanks,
Andrew
On 5/16/2013 11:25 PM, Vadim Pakhnushev wrote:
Phil, Andrew,
Would you please take a look at this updated fix posted half a year ago?
Thanks,
Vadim
On 20.11.2012 22:14, Vadim Pakhnushev wrote:
Phil,
That's right, interlaced images works
Looks great.
Thanks,
Andrew
On 5/16/2013 11:23 PM, Vadim Pakhnushev wrote:
Hi,
Please review the fix for 8000936:
http://bugs.sun.com/view_bug.do?bug_id=8000936
http://cr.openjdk.java.net/~vadim/8000936/webrev.00/
The fix enables D3D pipeline on Intel graphic chipsets starting from
GMA 4500
An excellent example of why email doesn't make for a great code
reviewing tool ..
Approved.
-phil.
On 5/16/2013 12:25 PM, Vadim Pakhnushev wrote:
Phil, Andrew,
Would you please take a look at this updated fix posted half a year ago?
Thanks,
Vadim
On 20.11.2012 22:14, Vadim Pakhnushev wrote
On May 15, 2013, at 4:00 PM, Phil Race wrote:
> It *initialises* all those classes ? Meaning their static initialisers
> might run, call native methods in a library which expect things to have
> been done in a different order ? Maybe the library isn't even loaded yet?
> I presume this must be hap
Perhaps I should throw an ExceptionInInitializerError w a CompileTheWorld
message?
--mm
On May 16, 2013, at 6:02 PM, John Rose wrote:
> On May 15, 2013, at 4:00 PM, Phil Race wrote:
>
>> It *initialises* all those classes ? Meaning their static initialisers
>> might run, call native me
On May 16, 2013, at 3:28 PM, Morris Meyer wrote:
> Perhaps I should throw an ExceptionInInitializerError w a CompileTheWorld
> message?
That goes farther beyond native code hardening than I was thinking. If I were
Phil I'd be uncomfortable with that, because it appears to create more of a
co
I agree, that I don't think we need to go so far as that. I've concluded
that the
original proposed fix appears harmless and is very probably OK and the
low incidence of such CTW issues over the years is surprising but
reassuring.
I've been waiting (all afternoon!) for my fastdebug (*) build to
12 matches
Mail list logo
