Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-11 Thread Andrew Brygin
Hello Phil, the fix looks fine to me. Thanks, Andrew On 2/11/2014 2:48 AM, Phil Race wrote: On 2/10/2014 2:14 PM, Sergey Bylokhov wrote: Hi, Phil. - Should we catch situations, when the getParentFile will return null, and change 'return newDir.equals(existDir)' to 'return Objects.equals(n

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-02-11 Thread Anton V. Tarasov
Hi Jim, On 2/11/14 4:12 AM, Jim Graham wrote: Just out of curiosity, on a Mac there is support for @2x images where they get loaded and used (at half scale to preserve layout size) automatically for you. In that respect, the added resolution is hidden from the regular APIs and the developer d

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-02-11 Thread Jim Graham
Hi Anton, These comments are about future public API, but this current patch is about getting the mechanism working behind the scenes. I'm OK with proceeding with the current patch as it is (modulo the review feedback I gave) to get the mechanism working for the basic back buffer behind the

[OpenJDK 2D-Dev] RFR : 8034227: JDK9 Windows build failure in libdcpr

2014-02-11 Thread Phil Race
The closed source library dcpr (ductus) needs to reference a JNU function So an update is needed to a build file : This needs a quick review as I (ahem) pushed the closed part but not this ... not of relevance to open source users but on windows the closed sources won't build without this change.

Re: [OpenJDK 2D-Dev] RFR : 8034227: JDK9 Windows build failure in libdcpr

2014-02-11 Thread Jennifer Godinez
Looks good. - Jennifer On 02/11/2014 12:36 PM, Phil Race wrote: The closed source library dcpr (ductus) needs to reference a JNU function So an update is needed to a build file : This needs a quick review as I (ahem) pushed the closed part but not this ... not of relevance to open source users