Re: [OpenJDK 2D-Dev] RFR: 6 backports pf JNI fixes for OS X from JDK9 to 8u20

2014-03-31 Thread Sergey Bylokhov
Hi, Phil. Looks fine. On 30.03.2014 2:00, Phil Race wrote: Sergey & Jennifer, Please review/check 6 MacOSX backports of JNI correctness fixes of changes you previously reviewed& approved for JDK 9. They are all one per-file and exact copies of what was pushed into jdk9/client. I have tested

Re: [OpenJDK 2D-Dev] RFR: 8u20 backport of 8029008: JNI warning in sun/font

2014-03-31 Thread Jennifer Godinez
Looks good. - Jennifer On 3/28/2014 2:12 PM, Phil Race wrote: Please sanity check this backport .. Code : http://cr.openjdk.java.net/~prr/8029008.8u20/ Bug https://bugs.openjdk.java.net/browse/JDK-8029008 JDK 9 changeset :- http://hg.openjdk.java.net/jdk9/client/jdk/rev/f0f8960831c1 Note th

Re: [OpenJDK 2D-Dev] RFR: 8u20 backport of 8029008: JNI warning in sun/font

2014-03-31 Thread Sergey Bylokhov
Hi, Phil. looks good. On 29.03.2014 1:12, Phil Race wrote: Please sanity check this backport .. Code : http://cr.openjdk.java.net/~prr/8029008.8u20/ Bug https://bugs.openjdk.java.net/browse/JDK-8029008 JDK 9 changeset :- http://hg.openjdk.java.net/jdk9/client/jdk/rev/f0f8960831c1 Note that

Re: [OpenJDK 2D-Dev] RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-31 Thread Tim Bell
Hi Erik Looks good to me as well. Tim Looks good to me. /Magnus On 27 mar 2014, at 12:47, Erik Joelsson wrote: Further testing revealed some more issues. New webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ I had to break out the devkit/sysroot parts from from BASIC_SETU