Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-08 Thread Sergey Bylokhov
On Thu, 5 Nov 2020 17:52:19 GMT, Phil Race wrote: >> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an >> OpenType text shaping library >> >> https://bugs.openjdk.java.net/browse/JDK-8247872 >> >> This has passed building and headless and headful automated tests on all >>

[OpenJDK 2D-Dev] Integrated: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-08 Thread Phil Race
On Mon, 2 Nov 2020 04:19:57 GMT, Phil Race wrote: > This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platfo

Re: [OpenJDK 2D-Dev] RFR: 8255920: J2DBench should support CS_PYCC color profile

2020-11-08 Thread Phil Race
On Thu, 5 Nov 2020 07:15:32 GMT, Sergey Bylokhov wrote: > Support of the CS_PYCC color profile is added to the J2DBench. Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1072

Re: [OpenJDK 2D-Dev] RFR: 8255575: java.awt.color.ICC_ColorSpace is not thread-safe

2020-11-08 Thread Phil Race
On Thu, 5 Nov 2020 01:34:25 GMT, Sergey Bylokhov wrote: > The ICC_ColorSpace class uses a couple of internal data caches that might be > used w/o any synchronization by different threads. > > The solution is to wrap the initialization of the cached data by the DLC. I > have checked performance

Re: [OpenJDK 2D-Dev] RFR: 8255722: Create a new test for rotated blit [v2]

2020-11-08 Thread Phil Race
On Sat, 7 Nov 2020 01:45:09 GMT, Sergey Bylokhov wrote: >> I have worked on a possible improvement in the OGL blit logic, and right >> before PR creation found a critical bug that ruined the whole idea of the >> change. Unfortunately, non of the tests found this bug, so instead of a fix, >> I

Re: [OpenJDK 2D-Dev] RFR: 6847157: java.lang.NullPointerException: HDC for component at sun.java2d.loops.Blit.Blit

2020-11-08 Thread Phil Race
On Mon, 26 Oct 2020 19:45:49 GMT, Sergey Bylokhov wrote: > This is the fix for one suspicious exception which rarely but time to time > occurred on the test systems. As described in a few bug reports the use-cases > could be quite different, but I was able to reproduce it in one of them. > > S

Re: [OpenJDK 2D-Dev] RFR: 4619330: some of java.awt.color.ColorSpace fields should specified that build-in

2020-11-08 Thread Phil Race
On Tue, 27 Oct 2020 22:32:15 GMT, Sergey Bylokhov wrote: > The wording for ColorSpace.CS_XXX is unified. The change is fine but please update the commit message of the PR to match the updated synopsis of the bug report. It wasn't even a complete sentence. - Marked as reviewed by p

Re: [OpenJDK 2D-Dev] RFR: 8254863: Delete code leftover from old fixes

2020-11-08 Thread Phil Race
On Fri, 16 Oct 2020 02:31:09 GMT, Sergey Bylokhov wrote: > The fix for JDK-4893408 adds a special code to handle the "PYCC.pf" color > profile for the "kernel java": > https://bugs.openjdk.java.net/browse/JDK-4893408?focusedCommentId=12284308&page=com.atlassian.jira.plugin.system.issuetabpanels:

[OpenJDK 2D-Dev] Integrated: 8255722: Create a new test for rotated blit

2020-11-08 Thread Sergey Bylokhov
On Mon, 2 Nov 2020 02:58:09 GMT, Sergey Bylokhov wrote: > I have worked on a possible improvement in the OGL blit logic, and right > before PR creation found a critical bug that ruined the whole idea of the > change. Unfortunately, non of the tests found this bug, so instead of a fix, > I prop

[OpenJDK 2D-Dev] Integrated: 8255575: java.awt.color.ICC_ColorSpace is not thread-safe

2020-11-08 Thread Sergey Bylokhov
On Thu, 5 Nov 2020 01:34:25 GMT, Sergey Bylokhov wrote: > The ICC_ColorSpace class uses a couple of internal data caches that might be > used w/o any synchronization by different threads. > > The solution is to wrap the initialization of the cached data by the DLC. I > have checked performance

[OpenJDK 2D-Dev] Integrated: 8255920: J2DBench should support CS_PYCC color profile

2020-11-08 Thread Sergey Bylokhov
On Thu, 5 Nov 2020 07:15:32 GMT, Sergey Bylokhov wrote: > Support of the CS_PYCC color profile is added to the J2DBench. This pull request has now been integrated. Changeset: 3ce09c05 Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/3ce09c05 Stats: 4 lines in 1

[OpenJDK 2D-Dev] Integrated: 6847157: java.lang.NullPointerException: HDC for component at sun.java2d.loops.Blit.Blit

2020-11-08 Thread Sergey Bylokhov
On Mon, 26 Oct 2020 19:45:49 GMT, Sergey Bylokhov wrote: > This is the fix for one suspicious exception which rarely but time to time > occurred on the test systems. As described in a few bug reports the use-cases > could be quite different, but I was able to reproduce it in one of them. > > S