Re: [389-devel] Revised: please review replication code cleanup

2012-03-08 Thread Rich Megginson
On 03/08/2012 02:42 PM, Mark Reynolds wrote: I still missed some tabs, revised patch attached ack On 03/08/2012 04:28 PM, Mark Reynolds wrote: While working on ticket 271, I found that the code was almost unreadable in repl5_inc_run(). The tabs and spacing were all over the place. So w

Re: [389-devel] please review replication code cleanup

2012-03-08 Thread Rich Megginson
On 03/08/2012 02:28 PM, Mark Reynolds wrote: While working on ticket 271, I found that the code was almost unreadable in repl5_inc_run(). The tabs and spacing were all over the place. So wanted to get this "code cleanup" checked in before I start working on a fix, etc. ack Thanks, Mark -

[389-devel] Revised: please review replication code cleanup

2012-03-08 Thread Mark Reynolds
I still missed some tabs, revised patch attached On 03/08/2012 04:28 PM, Mark Reynolds wrote: While working on ticket 271, I found that the code was almost unreadable in repl5_inc_run(). The tabs and spacing were all over the place. So wanted to get this "code cleanup" checked in before I

[389-devel] please review replication code cleanup

2012-03-08 Thread Mark Reynolds
While working on ticket 271, I found that the code was almost unreadable in repl5_inc_run(). The tabs and spacing were all over the place. So wanted to get this "code cleanup" checked in before I start working on a fix, etc. Thanks, Mark >From bc631688e1715f7f59a9f84b08dfbe16432f96d8 Mon Sep

[389-devel] Please review: Ticket 317 - RHDS fractional replication with excluded password policy attri, butes leads to wrong error messages.

2012-03-08 Thread Rich Megginson
https://fedorahosted.org/389/ticket/317 https://fedorahosted.org/389/attachment/ticket/317/0001-Ticket-317-RHDS-fractional-replication-with-excluded.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] revised... please review ticket 308 - Automembership plugin deadlocks if data and config area mixed in the plugin configuration

2012-03-08 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/308 https://fedorahosted.org/389/attachment/ticket/308/0001-Ticket-308-Automembership-plugin-fails-if-data-and-c.patch Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel