Re: [389-devel] Please review lib389 ticket 47568: Rename DSAdmin class (2nd)

2013-10-25 Thread Roberto Polli
On Friday 25 October 2013 11:18:53 thierry bordaz wrote: lib389/brooker.py:795: python variable naming convention: I would get stick with the _ instead of camelCase and change whenever possible. If you prefer to use '_' also for local variable, I am fine. Using camel just for classes is

[389-devel] resent: please review: Ticket 47368 - IPA server dirsrv RUV entry data excluded from fractional replication

2013-10-25 Thread Mark Reynolds
Performance numbers look good with this patch (no significant impact). Resending this out for review... https://fedorahosted.org/389/ticket/47368 https://fedorahosted.org/389/attachment/ticket/47368/0001-Ticket-47368-IPA-server-dirsrv-RUV-entry-data-exclud.patch -- 389-devel mailing list

[389-devel] Proof of concept: mocking DS in lib389

2013-10-25 Thread Jan Rusnacko
Hello Roberto and Thierry, as I promised, I am sending you a proof-of-concept code that demonstrates, how we can mock DS in unit tests for library function (see attachment). You can run tests just by executing py.test in tests directory. Only 3 files are of interest here:

[389-devel] Please review: [389 Project] #47555: db2bak.pl issue when specifying non-default directory

2013-10-25 Thread Noriko Hosoi
https://fedorahosted.org/389/attachment/ticket/47555/0001-Ticket-47555-db2bak.pl-issue-when-specifying-non-def.patch Bug description: db2bak.pl takes an option -a backupdir, which is supposed to be generated by the server and used as a backup directory. But since the created directory