[389-devel] Please review: Fix slapi_td_plugin_lock_init prototype

2014-09-15 Thread Petr Viktorin
Hello, FreeIPA compilation gives a GCC warning in a 389-ds header: In file included from ipa_dns.c:54:0: /usr/include/dirsrv/slapi-plugin.h:5585:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] int slapi_td_plugin_lock_init(); ^ The attached patch should fix this.

[389-devel] please review: Ticket 47697 - Admin Server - Resource leak in dsalib_updown.c

2014-09-15 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/47697 https://fedorahosted.org/389/attachment/ticket/47697/0001-Ticket-47697-Resource-leak-in-lib-libdsa-dsalib_updo.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review: Ticket 47472 - idm console framework - Entries cannot be highlighted in Rights panel of Edit ACI for... window

2014-09-15 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/47472 https://fedorahosted.org/389/attachment/ticket/47472/0001-Ticket-47472-Entries-cannot-be-highlighted-in-the-Ed.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: Fix slapi_td_plugin_lock_init prototype

2014-09-15 Thread Rich Megginson
On 09/15/2014 05:20 AM, Petr Viktorin wrote: diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h index f1ecfe8..268e465 100644 --- a/ldap/servers/slapd/slapi-plugin.h +++ b/ldap/servers/slapd/slapi-plugin.h @@ -5582,7 +5582,7 @@ void slapi_td_get_val(int

Re: [389-devel] Please review: Fix slapi_td_plugin_lock_init prototype

2014-09-15 Thread Petr Viktorin
On 09/15/2014 09:06 PM, Rich Megginson wrote: On 09/15/2014 05:20 AM, Petr Viktorin wrote: diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h index f1ecfe8..268e465 100644 --- a/ldap/servers/slapd/slapi-plugin.h +++ b/ldap/servers/slapd/slapi-plugin.h @@ -5582,7

Re: [389-devel] Please review: Fix slapi_td_plugin_lock_init prototype

2014-09-15 Thread Rich Megginson
On 09/15/2014 07:28 PM, Petr Viktorin wrote: On 09/15/2014 09:06 PM, Rich Megginson wrote: On 09/15/2014 05:20 AM, Petr Viktorin wrote: diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h index f1ecfe8..268e465 100644 --- a/ldap/servers/slapd/slapi-plugin.h +++