Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-31 Thread thierry bordaz
On 10/31/2013 11:36 AM, Jan Rusnacko wrote: On 10/31/2013 11:27 AM, thierry bordaz wrote: On 10/30/2013 07:56 PM, Jan Rusnacko wrote: Hello Thierry, layout OK. As for tests - instead of reinventing the wheel by defing class Test_standAlone to set up instance, use py.test fixture. Also, you s

Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-31 Thread Jan Rusnacko
On 10/31/2013 11:27 AM, thierry bordaz wrote: > On 10/30/2013 07:56 PM, Jan Rusnacko wrote: >> Hello Thierry, >> >> layout OK. >> >> As for tests - instead of reinventing the wheel by defing class >> Test_standAlone >> to set up instance, use py.test fixture. >> >> Also, you should not force setup

Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-31 Thread thierry bordaz
On 10/30/2013 07:56 PM, Jan Rusnacko wrote: Hello Thierry, layout OK. As for tests - instead of reinventing the wheel by defing class Test_standAlone to set up instance, use py.test fixture. Also, you should not force setup, test, teardown execution for each test by specifying sub-methods for

Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-30 Thread Rich Megginson
On 10/30/2013 12:56 PM, Jan Rusnacko wrote: Hello Thierry, layout OK. As for tests - instead of reinventing the wheel by defing class Test_standAlone to set up instance, use py.test fixture. +1 Also, you should not force setup, test, teardown execution for each test by specifying sub-methods

Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-30 Thread Jan Rusnacko
Hello Thierry, layout OK. As for tests - instead of reinventing the wheel by defing class Test_standAlone to set up instance, use py.test fixture. Also, you should not force setup, test, teardown execution for each test by specifying sub-methods for each test. Testing framework (py.test) should

[389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-30 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47578/0001-Ticket-47578-CI-tests-removal-of-sudo-and-absolute-p.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel