Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread adr via 9fans
On Mon, 12 Jul 2021, adr via 9fans wrote: [...] the length of a data chunk must be less than 2^31 - 1 [...] can't be fixed (At least you want to allocate more than 2GB...) [...] Well... to be exact here, it can't be bigger than 2^31 - 1, so there are "almost" 2GB.

Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread adr via 9fans
On Mon, 12 Jul 2021, hiro wrote: Date: Mon, 12 Jul 2021 20:04:23 +0200 From: hiro <23h...@gmail.com> Reply-To: 9fans <9fans@9fans.net> To: 9fans <9fans@9fans.net> Subject: Re: [9fans] pngread: alloc chunk's length it's always useful to have the testcase available, for others and for possible fu

Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread hiro
it's always useful to have the testcase available, for others and for possible future regressions On 7/12/21, adr via 9fans <9fans@9fans.net> wrote: > On Mon, 12 Jul 2021, o...@eigenstate.org wrote: >> Do you have an example? > > I could upload it in some place but you don't need it, really. The

Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread adr via 9fans
On Mon, 12 Jul 2021, o...@eigenstate.org wrote: Do you have an example? I could upload it in some place but you don't need it, really. The specification is clear, the length of a data chunk must be less than 2^31 - 1, and the complete image data is represented by a single zlib datastream that i

Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread adr via 9fans
On Mon, 12 Jul 2021, o...@eigenstate.org wrote: Why not make getchunk allocate? Somethign like: --- //.git/fs/object/e8259861da3a55c03491904e4d11c5c15b7577c5/tree/sys/src/cmd/jpg/readpng.c +++ sys/src/cmd/jpg/readpng.c @@ -94,7 +94,7 @@ } static int -getchunk(Biobuf *b, char *type, uchar *d, in

Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread ori
Quoth adr via 9fans <9fans@9fans.net>: > because it couldn't open some png files Do you have an example? -- 9fans: 9fans Permalink: https://9fans.topicbox.com/groups/9fans/T4a714ed14c50767a-Mfc030872ffba9972709a61bd Delivery options: https://9fans.topicbo

Re: [9fans] pngread: alloc chunk's length

2021-07-12 Thread ori
Quoth adr via 9fans <9fans@9fans.net>: > Checking the sent mail I noticed that I forgot to remove mag... Why not make getchunk allocate? Somethign like: --- //.git/fs/object/e8259861da3a55c03491904e4d11c5c15b7577c5/tree/sys/src/cmd/jpg/readpng.c +++ sys/src/cmd/jpg/readpng.c @@ -94,7 +94,7 @@ }

[9fans] Zig support for plan 9

2021-07-12 Thread msh
I just saw this commit, and wanted to share the current progress, https://github.com/ziglang/zig/pull/9105 -- 9fans: 9fans Permalink: https://9fans.topicbox.com/groups/9fans/T08de1d569132e9ef-M992dc4b79a5be2fde0003dd9 Delivery options: https://9fans.topicb