Re: [Abook-devel] [PR] Updated German translation

Applied into latest -master. Thank you! On Thu, Aug 09, 2018 at 05:32:44PM +0200, Rieger Anton wrote: > Dear all, > > I noticed a missing German translation, so I thought to add it. > In the process I looked through the complete de.po and corrected/added > translations. > > Maybe I overloo

Re: [Abook-devel] [PATCH 2/2] Add --fields to tell which fields to get emails from

Thank you for the patchset Corey. Sounds good and safe. + it removed a gotcha about concatenating "From:" I just merged into -master + added a couple of wording fixes and a mention in --help. Note: To avoid possible misunderstandings I modified the original option name to --email-fields (i

Re: [Abook-devel] [Patch] abook.c, abook.h: add support for XDG_CONFIG_HOME and XDG_DATA_HOME respectively

Hi Andreas, Thank you very much for your contribution. It's definitely a good idea but there are several redundancies in the patch. and ~ 100 LoC added to abook.c. You may want to create small helpers like - `get_config_dir(int create_if_not_exists)` - `get_data_dir(int create_if_not_exists)` Wh