Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-02-25 Thread Francesca Palombini
Hi Ben, No worries, I took enough time answering your review, on the contrary thank you for making it before the interim! I saw you already reviewed the PR, otherwise you can see the diff with the latest submission more easily here: https://tools.ietf.org/rfcdiff?url1=https://tools.ietf.org/id/

Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-02-24 Thread Benjamin Kaduk
Hi Francesca, Sorry to cut this so close to the wire...I was on vacation and came back to a sizeable inbox. On Mon, Feb 17, 2020 at 03:55:29PM +, Francesca Palombini wrote: > Hi Ben, > > I am now done with updating the draft following most of your review comments. > Out of the 105, I have i

Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-02-17 Thread Francesca Palombini
Hi Ben, I am now done with updating the draft following most of your review comments. Out of the 105, I have implemented 88 in the draft, while those left need agreement in the wg as previously mentioned, or require your OK (see inline). You can see the result of the update in the PR here: htt

Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-02-02 Thread Benjamin Kaduk
On Wed, Jan 29, 2020 at 02:42:34PM +, Francesca Palombini wrote: > Hi Ben, > > Thank you so much for this very thorough and in-depth review! > > I have started a PR (https://github.com/ace-wg/ace-oscore-profile/pull/25 ) > where I plan to include all the review comments. I have started with

Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-02-02 Thread Benjamin Kaduk
On Thu, Jan 30, 2020 at 06:37:37PM -0800, Jim Schaad wrote: > > > -Original Message- > From: Ace On Behalf Of Francesca Palombini > Sent: Wednesday, January 29, 2020 6:43 AM > To: Benjamin Kaduk ; draft-ietf-ace-oscore-prof...@ietf.org; > Ace Wg > Subject: Re:

Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-01-30 Thread Jim Schaad
-Original Message- From: Ace On Behalf Of Francesca Palombini Sent: Wednesday, January 29, 2020 6:43 AM To: Benjamin Kaduk ; draft-ietf-ace-oscore-prof...@ietf.org; Ace Wg Subject: Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08 Hi Ben, Thank you so much for this very

Re: [Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-01-29 Thread Francesca Palombini
Hi Ben, Thank you so much for this very thorough and in-depth review! I have started a PR (https://github.com/ace-wg/ace-oscore-profile/pull/25 ) where I plan to include all the review comments. I have started with the editorial fixes, which I have collected in one issue: https://github.com/a

[Ace] AD review of draft-ietf-ace-oscore-profile-08

2020-01-07 Thread Benjamin Kaduk
Hi all, Some high-level points before the section-by-section commentary: I'm a little confused by the registry we are creating in Section 9.2. While it's clear that we need something to specify the CBOR map key labels to encode the structure for transit, it's not clear that we need easy extensibi